From 2910a541f809fda288f78476967441b5ba649b9c Mon Sep 17 00:00:00 2001 From: Konrad Adamczyk Date: Tue, 27 Jun 2023 12:44:43 +0000 Subject: [PATCH] soc/amd/common/fsp: Fix dimm_num assignment The dimm_num shall be dimm, not channel. BUG=b:288520486 TEST=In kernel, see output from `dmidecode -t 17`. Observe that Locator reflects proper location of the module. Change-Id: Id876a5c245ed1a145c930b3456830d7b42780b74 Signed-off-by: Konrad Adamczyk Reviewed-on: https://review.coreboot.org/c/coreboot/+/76108 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/soc/amd/common/fsp/dmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/amd/common/fsp/dmi.c b/src/soc/amd/common/fsp/dmi.c index a671476c9d..408c0e4c2b 100644 --- a/src/soc/amd/common/fsp/dmi.c +++ b/src/soc/amd/common/fsp/dmi.c @@ -226,7 +226,7 @@ static void prepare_dmi_16_17(void *unused) print_dmi_info(type17_dmi_info); dimm_info = &mem_info->dimm[dimm_cnt]; dimm_info->channel_num = channel; - dimm_info->dimm_num = channel; + dimm_info->dimm_num = dimm; transfer_memory_info(type17_dmi_info, dimm_info); if (use_cbi_part_number) { /* mem_info is memset to 0 above, so it's