sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/jasperlake: Update acoustic noise related parameters

Browse Source 
We need to fill Acoustic noise mitigation related UPDs only in
case when acoustic noise mitigation is enabled. This will also
clarify the user that they need to enable Acoustic noise
mitigation while using this config in mainboard.

We're only filling UPD for domain VR index 0 since there is only
one VR domain for JSL (VCCIN VR).
Reference: JSL EDS (Document# 613601) (Chapter 3.4)

BUG=None
BRANCH=dedede
TEST=UPD values are getting filled correctly when Acoustic noise
mitigation is enabled.

Change-Id: I0cf4ccfced13b0d32b3d20713eace63e66945332
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49187
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Evan Green <evgreen@chromium.org>
This commit is contained in:
Maulik V Vaghela
2021-01-06 22:04:37 +05:30
committed by Karthik Ramasubramanian
parent 830306cc84
commit 2e424ff2d7
2 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/soc/intel/jasperlake/fsp_params.c
View File

@@ -236,13 +236,20 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
config->PchPmSlpS3MinAssert, config->PchPmSlpAMinAssert,
config->PchPmPwrCycDur);
/* Fill Acoustic noise mitigation related configuration */
params->FastPkgCRampDisable[0] = config->FastPkgCRampDisable;
params->SlowSlewRate[0] = config->SlowSlewRate;
/*
* Fill Acoustic noise mitigation related configuration
* JSL only has single VR domain (VCCIN VR), thus filling only index 0 for
* Slew rate and FastPkgCRamp for VR0 only.
*/
params->AcousticNoiseMitigation = config->AcousticNoiseMitigation;
params->PreWake = config->PreWake;
params->RampUp = config->RampUp;
params->RampDown = config->RampDown;
if (params->AcousticNoiseMitigation) {
params->FastPkgCRampDisable[0] = config->FastPkgCRampDisable;
params->SlowSlewRate[0] = config->SlowSlewRate;
params->PreWake = config->PreWake;
params->RampUp = config->RampUp;
params->RampDown = config->RampDown;
}
/* Override/Fill FSP Silicon Param for mainboard */
mainboard_silicon_init_params(params);