Replace DEVICE_NOOP with noop_(set|read)_resources

`.read_resources` and `.set_resources` are the only two device
operations that are considered mandatory. Other function pointers
can be left NULL. Having dedicated no-op implementations for the
two mandatory fields should stop the leaking of no-op pointers to
other fields.

Change-Id: I6469a7568dc24317c95e238749d878e798b0a362
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40207
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber
2020-04-05 14:05:24 +02:00
committed by Angel Pons
parent a461b694a6
commit 2f8ba69b0e
80 changed files with 150 additions and 150 deletions

View File

@@ -122,7 +122,7 @@ static void ene932_init(struct device *dev)
static struct device_operations ops = {
.init = ene932_init,
.read_resources = DEVICE_NOOP,
.read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {

View File

@@ -438,7 +438,7 @@ static void lpc_ec_read_resources(struct device *dev)
static struct device_operations ops = {
.init = lpc_ec_init,
.read_resources = lpc_ec_read_resources,
.set_resources = DEVICE_NOOP,
.set_resources = noop_set_resources,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = google_chromeec_acpi_name,
.acpi_fill_ssdt = google_chromeec_fill_ssdt_generator,

View File

@@ -219,7 +219,7 @@ static const char *wilco_ec_acpi_name(const struct device *dev)
static struct device_operations ops = {
.init = wilco_ec_init,
.read_resources = wilco_ec_read_resources,
.set_resources = DEVICE_NOOP,
.set_resources = noop_set_resources,
.acpi_fill_ssdt = wilco_ec_fill_ssdt_generator,
.acpi_name = wilco_ec_acpi_name,
};

View File

@@ -132,7 +132,7 @@ static void ene_kb3940q_init(struct device *dev)
static struct device_operations ops = {
.init = ene_kb3940q_init,
.read_resources = DEVICE_NOOP,
.read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {

View File

@@ -146,7 +146,7 @@ static void it8518_init(struct device *dev)
static struct device_operations ops = {
.init = it8518_init,
.read_resources = DEVICE_NOOP,
.read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {

View File

@@ -35,7 +35,7 @@ static void it8518_init(struct device *dev)
static struct device_operations ops = {
.init = it8518_init,
.read_resources = DEVICE_NOOP,
.read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {