sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/gm45: Hook up PCI domain and CPU bus ops to devicetree

Browse Source 
Change-Id: I4a49f37e6fe0cb04c8112baf36fd8d01ab218045
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69293
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans
2022-11-07 09:45:19 +01:00
parent ea6a3b488c
commit 2fb6f68ef0
4 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/lenovo/t400/devicetree.cb
View File

@ -9,6 +9,7 @@ chip northbridge/intel/gm45
register "gpu_panel_power_cycle_delay" = "3" # T4: 200ms register "gpu_panel_power_cycle_delay" = "3" # T4: 200ms
device cpu_cluster 0 on device cpu_cluster 0 on
ops gm45_cpu_bus_ops
chip cpu/intel/socket_p chip cpu/intel/socket_p
device lapic 0 on end device lapic 0 on end
end end
@ -28,6 +29,7 @@ chip northbridge/intel/gm45
register "pci_mmio_size" = "2048" register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
ops gm45_pci_domain_ops
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x20e0 subsystemid 0x17aa 0x20e0
end # host bridge end # host bridge

2
src/mainboard/lenovo/x200/devicetree.cb
View File

@ -9,6 +9,7 @@ chip northbridge/intel/gm45
register "gpu_panel_power_cycle_delay" = "3" # T4: 200ms register "gpu_panel_power_cycle_delay" = "3" # T4: 200ms
device cpu_cluster 0 on device cpu_cluster 0 on
ops gm45_cpu_bus_ops
chip cpu/intel/socket_BGA956 chip cpu/intel/socket_BGA956
device lapic 0 on end device lapic 0 on end
end end
@ -28,6 +29,7 @@ chip northbridge/intel/gm45
register "pci_mmio_size" = "2048" register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
ops gm45_pci_domain_ops
device pci 00.0 on device pci 00.0 on
subsystemid 0x17aa 0x20e0 subsystemid 0x17aa 0x20e0
end # host bridge end # host bridge

2
src/mainboard/roda/rk9/devicetree.cb
View File

@ -2,6 +2,7 @@ chip northbridge/intel/gm45
# IGD Displays # IGD Displays
register "gfx" = "GMA_STATIC_DISPLAYS(0)" register "gfx" = "GMA_STATIC_DISPLAYS(0)"
device cpu_cluster 0 on device cpu_cluster 0 on
ops gm45_cpu_bus_ops
chip cpu/intel/socket_BGA956 chip cpu/intel/socket_BGA956
device lapic 0 on end device lapic 0 on end
end end
@ -21,6 +22,7 @@ chip northbridge/intel/gm45
register "pci_mmio_size" = "2048" register "pci_mmio_size" = "2048"
device domain 0 on device domain 0 on
ops gm45_pci_domain_ops
subsystemid 0x4352 0x8986 subsystemid 0x4352 0x8986
device pci 00.0 on end # host bridge device pci 00.0 on end # host bridge
device pci 02.0 on end # VGA device pci 02.0 on end # VGA

15
src/northbridge/intel/gm45/northbridge.c
View File

@ -200,7 +200,7 @@ static void pci_domain_ssdt(const struct device *dev)
set_above_4g_pci(dev); set_above_4g_pci(dev);
} }
static struct device_operations pci_domain_ops = { struct device_operations gm45_pci_domain_ops = {
.read_resources = mch_domain_read_resources, .read_resources = mch_domain_read_resources,
.set_resources = mch_domain_set_resources, .set_resources = mch_domain_set_resources,
.init = mch_domain_init, .init = mch_domain_init,
@ -210,22 +210,12 @@ static struct device_operations pci_domain_ops = {
.acpi_name = northbridge_acpi_name, .acpi_name = northbridge_acpi_name,
}; };
static struct device_operations cpu_bus_ops = { struct device_operations gm45_cpu_bus_ops = {
.read_resources = noop_read_resources, .read_resources = noop_read_resources,
.set_resources = noop_set_resources, .set_resources = noop_set_resources,
.init = mp_cpu_bus_init, .init = mp_cpu_bus_init,
}; };
static void enable_dev(struct device *dev)
{
/* Set the operations if it is a special bus type */
if (dev->path.type == DEVICE_PATH_DOMAIN) {
dev->ops = &pci_domain_ops;
} else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
dev->ops = &cpu_bus_ops;
}
}
static void gm45_init(void *const chip_info) static void gm45_init(void *const chip_info)
{ {
int dev, fn, bit_base; int dev, fn, bit_base;
@ -265,6 +255,5 @@ static void gm45_init(void *const chip_info)
struct chip_operations northbridge_intel_gm45_ops = { struct chip_operations northbridge_intel_gm45_ops = {
CHIP_NAME("Intel GM45 Northbridge") CHIP_NAME("Intel GM45 Northbridge")
.enable_dev = enable_dev,
.init = gm45_init, .init = gm45_init,
}; };