sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/ironlake: Reserve gap betwen TSEG and BGSM

Browse Source 
There may be a gap between TSEG and the graphics stolen memory due to
the alignment done in `raminit.c`. If we allocate MMIO resources in
this range, it misbehaves unpredictably, so reserve it.

TEST=Booted Thinkpad X201s, allocated resources are above TOLUD.

Change-Id: If305e9751ebf4edc945cf038ed72698f3696e52d
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45325
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber
2020-09-13 21:59:14 +02:00
parent 08e8e47d03
commit 308540de80
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/northbridge/intel/ironlake/northbridge.c
View File

@@ -92,7 +92,7 @@ static struct device_operations pci_domain_ops = {
static void mc_read_resources(struct device *dev) static void mc_read_resources(struct device *dev)
{ {
uint32_t tseg_base; uint32_t tseg_base, tseg_end;
uint64_t touud; uint64_t touud;
uint16_t reg16; uint16_t reg16;
int index = 3; int index = 3;
@@ -102,6 +102,7 @@ static void mc_read_resources(struct device *dev)
mmconf_resource(dev, 0x50); mmconf_resource(dev, 0x50);
tseg_base = pci_read_config32(pcidev_on_root(0, 0), TSEG); tseg_base = pci_read_config32(pcidev_on_root(0, 0), TSEG);
tseg_end = tseg_base + CONFIG_SMM_TSEG_SIZE;
touud = pci_read_config16(pcidev_on_root(0, 0), touud = pci_read_config16(pcidev_on_root(0, 0),
TOUUD); TOUUD);
@@ -131,6 +132,11 @@ static void mc_read_resources(struct device *dev)
pci_read_config32(pcidev_on_root(0, 0), IGD_BASE); pci_read_config32(pcidev_on_root(0, 0), IGD_BASE);
gtt_base = gtt_base =
pci_read_config32(pcidev_on_root(0, 0), GTT_BASE); pci_read_config32(pcidev_on_root(0, 0), GTT_BASE);
if (gtt_base > tseg_end) {
/* Reserve the gap. MMIO doesn't work in this range. Keep
it uncacheable, though, for easier MTRR allocation. */
mmio_resource(dev, index++, tseg_end >> 10, (gtt_base - tseg_end) >> 10);
}
mmio_resource(dev, index++, gtt_base >> 10, uma_size_gtt << 10); mmio_resource(dev, index++, gtt_base >> 10, uma_size_gtt << 10);
mmio_resource(dev, index++, igd_base >> 10, uma_size_igd << 10); mmio_resource(dev, index++, igd_base >> 10, uma_size_igd << 10);