sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve coreboot build output and eliminate some warnings:

Browse Source 
- Add static and const where possible.

 - Turn some #warning entries into TODO comments.

 - Add missing prototypes.

 - Remove unused variables.

 - Fix printf arguments or cast them as needed.

 - Make sconfig output look better. Drop useless "PARSED THE TREE" output.

 - Print "(this may take a while)" while building romcc. Add missing "\n".

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watosn <mylesgw@gmail.com>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4874 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Uwe Hermann
2009-10-27 21:49:33 +00:00
parent a8888bd1d2
commit 312673ca72
18 changed files with 41 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/arch/i386/boot/gdt.c
View File

@@ -47,11 +47,11 @@ void move_gdt(void)
printk(BIOS_ERR, "Error: Could not relocate GDT.\n");
return;
}
printk_debug("Moving GDT to %#lx...", newgdt);
printk_debug("Moving GDT to %p...", newgdt);
memcpy((void*)newgdt, &gdt, num_gdt_bytes);
}
gdtarg.base = newgdt;
gdtarg.base = (u32)newgdt;
gdtarg.limit = num_gdt_bytes - 1;
__asm__ __volatile__ ("lgdt %0\n\t" : : "m" (gdtarg));

4
src/arch/i386/boot/tables.c
View File

@@ -191,7 +191,7 @@ struct lb_memory *write_tables(void)
#define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
post_code(0x9d);
high_table_pointer = cbmem_add(CBMEM_ID_CBTABLE, MAX_COREBOOT_TABLE_SIZE);
high_table_pointer = (unsigned long)cbmem_add(CBMEM_ID_CBTABLE, MAX_COREBOOT_TABLE_SIZE);
if (high_table_pointer) {
unsigned long new_high_table_pointer;
@@ -202,7 +202,7 @@ struct lb_memory *write_tables(void)
if (new_high_table_pointer > (high_table_pointer +
MAX_COREBOOT_TABLE_SIZE))
printk_err("%s: coreboot table didn't fit (%llx)\n",
printk_err("%s: coreboot table didn't fit (%lx)\n",
__func__, new_high_table_pointer -
high_table_pointer);

4
src/arch/i386/lib/pci_ops_auto.c
View File

@@ -43,7 +43,7 @@ static int pci_sanity_check(const struct pci_bus_operations *o)
struct pci_bus_operations *pci_bus_fallback_ops = NULL;
const struct pci_bus_operations *pci_check_direct(void)
static const struct pci_bus_operations *pci_check_direct(void)
{
unsigned int tmp;
@@ -86,7 +86,7 @@ const struct pci_bus_operations *pci_check_direct(void)
const struct pci_bus_operations *pci_remember_direct(void)
{
if (!pci_bus_fallback_ops)
pci_bus_fallback_ops = pci_check_direct();
pci_bus_fallback_ops = (struct pci_bus_operations *)pci_check_direct();
return pci_bus_fallback_ops;
}