Improve coreboot build output and eliminate some warnings:
- Add static and const where possible. - Turn some #warning entries into TODO comments. - Add missing prototypes. - Remove unused variables. - Fix printf arguments or cast them as needed. - Make sconfig output look better. Drop useless "PARSED THE TREE" output. - Print "(this may take a while)" while building romcc. Add missing "\n". Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Myles Watosn <mylesgw@gmail.com> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4874 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
@@ -671,8 +671,11 @@ static void avoid_fixed_resources(struct device *dev)
|
||||
device_t vga_pri = 0;
|
||||
static void set_vga_bridge_bits(void)
|
||||
{
|
||||
#warning "FIXME modify set_vga_bridge so it is less pci centric!"
|
||||
#warning "This function knows too much about PCI stuff, it should be just a iterator/visitor."
|
||||
/*
|
||||
* FIXME: Modify set_vga_bridge so it is less PCI centric!
|
||||
* This function knows too much about PCI stuff, it should be just
|
||||
* an iterator/visitor.
|
||||
*/
|
||||
|
||||
/* FIXME: Handle the VGA palette snooping. */
|
||||
struct device *dev, *vga, *vga_onboard, *vga_first, *vga_last;
|
||||
|
Reference in New Issue
Block a user