Improve coreboot build output and eliminate some warnings:
- Add static and const where possible. - Turn some #warning entries into TODO comments. - Add missing prototypes. - Remove unused variables. - Fix printf arguments or cast them as needed. - Make sconfig output look better. Drop useless "PARSED THE TREE" output. - Print "(this may take a while)" while building romcc. Add missing "\n". Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Myles Watosn <mylesgw@gmail.com> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4874 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
@@ -886,7 +886,7 @@ def dumptree(part, lvl):
|
||||
|
||||
def writecode(image):
|
||||
filename = os.path.join(img_dir, "static.c")
|
||||
print "Creating", filename
|
||||
print " SCONFIG Creating", os.path.basename(filename)
|
||||
file = safe_open(filename, 'w+')
|
||||
file.write("#include <device/device.h>\n")
|
||||
file.write("#include <device/pci.h>\n")
|
||||
@@ -920,7 +920,7 @@ def gencode(part, file, pass_num):
|
||||
|
||||
def writegraph(image):
|
||||
filename = os.path.join(img_dir, "static.dot")
|
||||
print "Creating", filename
|
||||
print " SCONFIG Creating", os.path.basename(filename)
|
||||
file = safe_open(filename, 'w+')
|
||||
file.write("digraph devicetree {\n")
|
||||
file.write(" rankdir=LR\n")
|
||||
@@ -1015,7 +1015,6 @@ if __name__=='__main__':
|
||||
fp = safe_open(config_file, 'r')
|
||||
if (not parse('devicetree', fp.read())):
|
||||
fatal("Could not parse file")
|
||||
print "PARSED THE TREE"
|
||||
partstack.pop()
|
||||
|
||||
img_dir = argv[3]
|
||||
|
@@ -126,8 +126,8 @@ def generate(inputfilename, outputfilename='', dump=0, **flags):
|
||||
if inputfilename[-2:]=='.g': outputfilename = inputfilename[:-2]+'.py'
|
||||
else: raise "Invalid Filename", outputfilename
|
||||
|
||||
print 'Input Grammar:', inputfilename
|
||||
print 'Output File:', outputfilename
|
||||
print ' SCONFIG Input Grammar:', os.path.basename(inputfilename)
|
||||
print ' SCONFIG Output File:', os.path.basename(outputfilename)
|
||||
|
||||
DIVIDER = '\n%%\n' # This pattern separates the pre/post parsers
|
||||
preparser, postparser = None, None # Code before and after the parser desc
|
||||
|
@@ -18,6 +18,7 @@
|
||||
from string import *
|
||||
from yappsrt import *
|
||||
import re
|
||||
import os.path
|
||||
|
||||
INDENT = " "*4
|
||||
|
||||
@@ -709,8 +710,8 @@ def generate(inputfilename, outputfilename='', dump=0, **flags):
|
||||
if inputfilename[-2:]=='.g': outputfilename = inputfilename[:-2]+'.py'
|
||||
else: raise "Invalid Filename", outputfilename
|
||||
|
||||
print 'Input Grammar:', inputfilename
|
||||
print 'Output File:', outputfilename
|
||||
print ' SCONFIG Input Grammar:', os.path.basename(inputfilename)
|
||||
print ' SCONFIG Output File:', os.path.basename(outputfilename)
|
||||
|
||||
DIVIDER = '\n%%\n' # This pattern separates the pre/post parsers
|
||||
preparser, postparser = None, None # Code before and after the parser desc
|
||||
|
Reference in New Issue
Block a user