sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/cache: CLFLUSH programs to memory before running

Browse Source 
When cbmem is initialized in romstage and postcar placed in the stage
cache + cbmem where it is run, the assumption is made that these are
all in UC memory such that calling INVD in postcar is OK.

For performance reasons (e.g. postcar decompression) it is desirable
to cache cbmem and the stage cache during romstage.

Another reason is that AGESA sets up MTRR during romstage to cache all
dram, which is currently worked around by using additional MTRR's to
make that UC.

TESTED on asus/p5ql-em, up/squared on both regular and S3 resume
       bootpath. Sometimes there are minimal performance improvements
       when cbmem is cached (few ms).

Change-Id: I7ff2a57aee620908b71829457ea0f5a0c410ec5b
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37196
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans
2019-11-25 12:20:01 +01:00
committed by Lean Sheng Tan
parent 4bad919ce4
commit 3134a81525
6 changed files with 92 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/arch/x86/postcar_loader.c
View File

@@ -9,6 +9,7 @@
#include <program_loading.h>
#include <reset.h>
#include <rmodule.h>
#include <romstage_handoff.h>
#include <security/vboot/vboot_common.h>
#include <stage_cache.h>
#include <timestamp.h>
@@ -137,6 +138,25 @@ static void postcar_cache_invalid(void)
board_reset();
}
/*
* POSTCAR will call invd so don't make assumptions on cbmem
* and external stage cache being UC.
*/
static void postcar_flush_cache(void)
{
uintptr_t cbmem_base;
size_t cbmem_size;
uintptr_t stage_cache_base;
size_t stage_cache_size;
cbmem_get_region((void **)&cbmem_base, &cbmem_size);
prog_segment_loaded(cbmem_base, cbmem_size, SEG_FINAL);
if (CONFIG(TSEG_STAGE_CACHE) && !romstage_handoff_is_resume()) {
stage_cache_external_region((void **)&stage_cache_base, &stage_cache_size);
prog_segment_loaded(stage_cache_base, stage_cache_size, SEG_FINAL);
}
}
static void run_postcar_phase(struct postcar_frame *pcf)
{
struct prog prog =
@@ -159,6 +179,8 @@ static void run_postcar_phase(struct postcar_frame *pcf)
console_time_report();
postcar_flush_cache();
prog_set_arg(&prog, cbmem_top());
prog_run(&prog);