sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/x200: Fix docking events

Browse Source 
Even though `device` entries are children of `chip` entries in the
devicetree source format, the chips in the translated C structures
are only hooked up to device nodes. Hence, to configure a chip in
a device- or overridetree, it always needs a `device` below it.

This should fix docking events for the X200 ThinkPad.

Change-Id: I561e7ae81f2e096a091868ce51daa1c8f66af067
Signed-off-by: Nico Huber <nico.h@gmx.de>
Found-by: Kevin Keijzer <kevin@quietlife.nl>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51118
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Kevin Keijzer
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Nico Huber
2021-02-28 15:23:59 +01:00
committed by Patrick Georgi
parent 1037e34123
commit 3173f857b6
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/lenovo/x200/variants/x200/overridetree.cb
View File

@ -16,6 +16,7 @@ chip northbridge/intel/gm45
device pci 1f.0 on # LPC bridge device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7 chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
register "dock_event_enable" = "0x01" register "dock_event_enable" = "0x01"
end end
chip superio/nsc/pc87382 chip superio/nsc/pc87382