sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/nsc/pc87309: Avoid .c includes in mainboard

Browse Source 
Make superio romstage component link-time symbols.

Change-Id: Icde27465a05946498ff7b8f1aaa7a9e8ba074272
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5880
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan 2014-05-29 14:43:39 +10:00 committed by Kyösti Mälkki
parent beb0f2631f
commit 32da8d900e
4 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/tyan/s1846/romstage.c
View File

@ -30,7 +30,7 @@
#include "drivers/pc80/udelay_io.c" #include "drivers/pc80/udelay_io.c"
#include "lib/delay.c" #include "lib/delay.c"
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include "superio/nsc/pc87309/early_serial.c" #include <superio/nsc/pc87309/pc87309.h>
#include <lib.h> #include <lib.h>
#define SERIAL_DEV PNP_DEV(0x2e, PC87309_SP1) #define SERIAL_DEV PNP_DEV(0x2e, PC87309_SP1)

2
src/superio/nsc/pc87309/Makefile.inc
View File

@ -18,5 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_NSC_PC87309) += early_serial.c
ramstage-$(CONFIG_SUPERIO_NSC_PC87309) += superio.c ramstage-$(CONFIG_SUPERIO_NSC_PC87309) += superio.c

3
src/superio/nsc/pc87309/early_serial.c
View File

@ -19,9 +19,10 @@
*/ */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp_def.h>
#include "pc87309.h" #include "pc87309.h"
static void pc87309_enable_serial(device_t dev, u16 iobase) void pc87309_enable_serial(device_t dev, u16 iobase)
{ {
pnp_set_logical_device(dev); pnp_set_logical_device(dev);
pnp_set_enable(dev, 0); pnp_set_enable(dev, 0);

11
src/superio/nsc/pc87309/pc87309.h
View File

@ -18,8 +18,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#ifndef SUPERIO_NSC_PC87309_PC87309_H #ifndef SUPERIO_NSC_PC87309_H
#define SUPERIO_NSC_PC87309_PC87309_H #define SUPERIO_NSC_PC87309_H
/* Datasheet: PC87309 SuperI/O Plug and Play Compatible Chip. */ /* Datasheet: PC87309 SuperI/O Plug and Play Compatible Chip. */
@ -31,4 +31,9 @@
#define PC87309_KBCM 0x05 /* Mouse */ #define PC87309_KBCM 0x05 /* Mouse */
#define PC87309_KBCK 0x06 /* Keyboard */ #define PC87309_KBCK 0x06 /* Keyboard */
#endif #include <arch/io.h>
#include <stdint.h>
void pc87309_enable_serial(device_t dev, u16 iobase);
#endif /* SUPERIO_NSC_PC87309_H */