sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/starlabs/merlin: Remove comment about OPWE

Browse Source 
OPWE offset didn't exist, but it does now so remove the comment about
this.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I4a1310c779002dfb00d01a22437ea223bb406609
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63171
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Sean Rhodes
2022-03-29 08:14:39 +01:00
committed by Felix Held
parent 32528976ff
commit 32ec4526a0
7 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ec/starlabs/merlin/variants/apl/emem.asl
View File

@@ -98,10 +98,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
BT1T, 16, // Bt1 Temperature BT1T, 16, // Bt1 Temperature
BT1C, 8, // Bt1 Control BT1C, 8, // Bt1 Control
// Unicorn - doesn't actually exist
Offset(0x9d), Offset(0x9d),
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xbf), Offset(0xbf),
EJ8A, 8, // EJ898A Firmware Version EJ8A, 8, // EJ898A Firmware Version

2
src/ec/starlabs/merlin/variants/cml/emem.asl
View File

@@ -108,10 +108,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
BT1T, 16, // Bt1 Temperature BT1T, 16, // Bt1 Temperature
BT1C, 8, // Bt1 Control BT1C, 8, // Bt1 Control
// Unicorn - doesn't actually exist
Offset(0x9d), Offset(0x9d),
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xa0), Offset(0xa0),
UCSV, 16, // UCSI DS Version UCSV, 16, // UCSI DS Version

2
src/ec/starlabs/merlin/variants/glk/emem.asl
View File

@@ -98,10 +98,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
BT1T, 16, // Bt1 Temperature BT1T, 16, // Bt1 Temperature
BT1C, 8, // Bt1 Control BT1C, 8, // Bt1 Control
// Unicorn - doesn't actually exist
Offset(0x9d), Offset(0x9d),
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xbf), Offset(0xbf),
EJ8A, 8, // EJ898A Firmware Version EJ8A, 8, // EJ898A Firmware Version

2
src/ec/starlabs/merlin/variants/glkr/emem.asl
View File

@@ -69,10 +69,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
BT1T, 16, // Bt1 Temperature BT1T, 16, // Bt1 Temperature
BT1C, 8, // Bt1 Control BT1C, 8, // Bt1 Control
// Unicorn - doesn't actually exist
Offset(0x9d), Offset(0x9d),
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xa0), Offset(0xa0),
BSNL, 8, // Battery Serial Number Low byte BSNL, 8, // Battery Serial Number Low byte

2
src/ec/starlabs/merlin/variants/kbl/emem.asl
View File

@@ -85,10 +85,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
BPRP, 8, // Battery Remaining percentage BPRP, 8, // Battery Remaining percentage
BT1A, 8, // Bt1 ASOC BT1A, 8, // Bt1 ASOC
// Unicorn - doesn't actually exist
Offset(0x9d), Offset(0x9d),
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xbf), Offset(0xbf),
EJ8A, 8, // EJ898A Firmware Version EJ8A, 8, // EJ898A Firmware Version

2
src/ec/starlabs/merlin/variants/merlin/emem.asl
View File

@@ -91,10 +91,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
BATT, 16, // Battery Temperature BATT, 16, // Battery Temperature
BATC, 8, // Battery Temperature Ces BATC, 8, // Battery Temperature Ces
// Unicorn - doesn't actually exist
Offset(0x9d), // OPM: Offset(0x9d), // OPM:
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xb0), // MGO; Offset(0xb0), // MGO;
MGO0, 8, // UCSI DS MGO 0 MGO0, 8, // UCSI DS MGO 0

2
src/ec/starlabs/merlin/variants/tgl/emem.asl
View File

@@ -98,10 +98,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
B1PV, 16, // Battery Present Voltage B1PV, 16, // Battery Present Voltage
BPRP, 8, // Battery Remaining percentage BPRP, 8, // Battery Remaining percentage
// Unicorn - doesn't actually exist
Offset(0x9d), Offset(0x9d),
OPWE, 8, // OPM write to EC flag for UCSI OPWE, 8, // OPM write to EC flag for UCSI
// Unicorn - doesn't actually exist
Offset(0xb0), Offset(0xb0),
MGO0, 8, // UCSI DS MGO 0 MGO0, 8, // UCSI DS MGO 0