sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfstool: Make endian detection functions to work without prior setup.

Browse Source 
The 'host_bigendian' variable (and functions relying on it like ntohl/htonl)
requires host detection by calling static which_endian() first -- which may be
easily forgotten by developers.  It's now a public function in common.c and
doesn't need initialization anymore.

Change-Id: I13dabd1ad15d2d6657137d29138e0878040cb205
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: http://review.coreboot.org/2199
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Hung-Te Lin
2013-01-28 15:53:34 +08:00
parent d723c5b554
commit 332795cc59
4 changed files with 21 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
util/cbfstool/cbfstool.c
View File

@@ -496,18 +496,6 @@ static void usage(char *name)
print_supported_filetypes();
}
/* Small, OS/libc independent runtime check for endianess */
int host_bigendian = 0;
static void which_endian(void)
{
static const uint32_t inttest = 0x12345678;
uint8_t inttest_lsb = *(uint8_t *)&inttest;
if (inttest_lsb == 0x12) {
host_bigendian = 1;
}
}
int main(int argc, char **argv)
{
size_t i;
@@ -518,8 +506,6 @@ int main(int argc, char **argv)
return 1;
}
which_endian();
param.cbfs_name = argv[1];
char *cmd = argv[2];
optind += 2;