soc/amd/picasso: introduce and use devicetree aliases for UART0-3

Since the default state of the MMIO UART devices in the chipset
devicetree is off, the mainboard devicetree entries that disable MMIO
UART devices are removed.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I913a587802020ce4e182b48632cdde1104c2a6e6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55545
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/mainboard/amd/bilby/devicetree.cb

@@ -165,9 +165,7 @@ chip soc/amd/picasso
 		end
 	end # domain
 
-	device mmio 0xfedc9000 on  end # UART0
+	device ref uart_0 on end # console
-	device mmio 0xfedca000 on  end # UART1
+	device ref uart_1 on end
-	device mmio 0xfedce000 off end # UART2
-	device mmio 0xfedcf000 off end # UART3
 
 end	# chip soc/amd/picasso

src/mainboard/amd/mandolin/variants/cereme/devicetree.cb

@@ -163,9 +163,7 @@ chip soc/amd/picasso
 		end
 	end # domain
 
-	device mmio 0xfedc9000 on  end # UART0
+	device ref uart_0 on end # console
-	device mmio 0xfedca000 on  end # UART1
+	device ref uart_1 on end
-	device mmio 0xfedce000 off end # UART2
-	device mmio 0xfedcf000 off end # UART3
 
 end	# chip soc/amd/picasso

src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb

@@ -163,9 +163,7 @@ chip soc/amd/picasso
 		end
 	end # domain
 
-	device mmio 0xfedc9000 on  end # UART0
+	device ref uart_0 on end # console
-	device mmio 0xfedca000 on  end # UART1
+	device ref uart_1 on end
-	device mmio 0xfedce000 off end # UART2
-	device mmio 0xfedcf000 off end # UART3
 
 end	# chip soc/amd/picasso

src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb

@@ -395,9 +395,6 @@ chip soc/amd/picasso
 		end
 	end
 
-	device mmio 0xfedc9000 on end # console on UART0
+	device ref uart_0 on end # console
-	device mmio 0xfedca000 off end # UART1
-	device mmio 0xfedce000 off end # UART2
-	device mmio 0xfedcf000 off end # UART3
 
 end	# chip soc/amd/picasso

src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb

@@ -437,9 +437,6 @@ chip soc/amd/picasso
 		end
 	end
 
-	device mmio 0xfedc9000 on end # console on UART0
+	device ref uart_0 on end # console
-	device mmio 0xfedca000 off end # UART1
-	device mmio 0xfedce000 off end # UART2
-	device mmio 0xfedcf000 off end # UART3
 
 end	# chip soc/amd/picasso

src/mainboard/google/zork/variants/berknip/overridetree.cb

@@ -158,7 +158,7 @@ chip soc/amd/picasso
 		end
 	end
 
-	device mmio 0xfedca000 on
+	device ref uart_1 on
 		chip drivers/uart/acpi
 			register "name" = ""CRFP""
 			register "desc" = ""Fingerprint Reader""

src/mainboard/google/zork/variants/morphius/overridetree.cb

@@ -123,7 +123,7 @@ chip soc/amd/picasso
 		end
 	end
 
-	device mmio 0xfedca000 on
+	device ref uart_1 on
 		chip drivers/uart/acpi
 			register "name" = ""CRFP""
 			register "desc" = ""Fingerprint Reader""

src/mainboard/google/zork/variants/trembyle/overridetree.cb

@@ -91,7 +91,7 @@ chip soc/amd/picasso
 		end
 	end
 
-	device mmio 0xfedca000 on
+	device ref uart_1 on
 		chip drivers/uart/acpi
 			register "name" = ""CRFP""
 			register "desc" = ""Fingerprint Reader""

src/soc/amd/picasso/chipset.cb

@@ -46,4 +46,8 @@ chip soc/amd/picasso
 
 	device mmio 0xfedc4000 alias i2c_2 off end
 	device mmio 0xfedc5000 alias i2c_3 off end
+	device mmio 0xfedc9000 alias uart_0 off end
+	device mmio 0xfedca000 alias uart_1 off end
+	device mmio 0xfedce000 alias uart_2 off end
+	device mmio 0xfedcf000 alias uart_3 off end
 end