sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge/raminit: Reduce log level

Browse Source 
Silency noisy raminit logging by:
* Removing verbose logging from loops.
* Printing detailed summary at end of loop instead.
* Using the same scheme already present in some functions.

Change-Id: I412d81592436ac0d2422caf396c64e0c34acc2d1
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/17611
Tested-by: build bot (Jenkins)
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Patrick Rudolph
2016-11-25 16:36:52 +01:00
committed by Martin Roth
parent 3c8cb97ea7
commit 368b615243
1 changed files with 8 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/northbridge/intel/sandybridge/raminit_common.c
View File

@@ -1223,9 +1223,6 @@ static void discover_timA_coarse(ramctr_timing * ctrl, int channel,
FOR_ALL_LANES { FOR_ALL_LANES {
statistics[lane][timA] = statistics[lane][timA] =
!does_lane_work(ctrl, channel, slotrank, lane); !does_lane_work(ctrl, channel, slotrank, lane);
printram("Astat: %d, %d, %d: %x, %x\n",
channel, slotrank, lane, timA,
statistics[lane][timA]);
} }
} }
FOR_ALL_LANES { FOR_ALL_LANES {
@@ -1234,10 +1231,8 @@ static void discover_timA_coarse(ramctr_timing * ctrl, int channel,
upperA[lane] = rn.end; upperA[lane] = rn.end;
if (upperA[lane] < rn.middle) if (upperA[lane] < rn.middle)
upperA[lane] += 128; upperA[lane] += 128;
printram("Aval: %d, %d, %d: %x\n", channel, slotrank, printram("timA: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n",
lane, ctrl->timings[channel][slotrank].lanes[lane].timA); channel, slotrank, lane, rn.start, rn.middle, rn.end);
printram("Aend: %d, %d, %d: %x\n", channel, slotrank,
lane, upperA[lane]);
} }
} }
@@ -1614,9 +1609,6 @@ static int discover_timC(ramctr_timing *ctrl, int channel, int slotrank)
statistics[lane][timC] = statistics[lane][timC] =
read32(DEFAULT_MCHBAR + 0x4340 + 4 * lane + read32(DEFAULT_MCHBAR + 0x4340 + 4 * lane +
0x400 * channel); 0x400 * channel);
printram("Cstat: %d, %d, %d, %x, %x\n",
channel, slotrank, lane, timC,
statistics[lane][timC]);
} }
} }
FOR_ALL_LANES { FOR_ALL_LANES {
@@ -1628,8 +1620,8 @@ static int discover_timC(ramctr_timing *ctrl, int channel, int slotrank)
channel, slotrank, lane); channel, slotrank, lane);
return MAKE_ERR; return MAKE_ERR;
} }
printram("Cval: %d, %d, %d: %x\n", channel, slotrank, printram("timC: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n",
lane, ctrl->timings[channel][slotrank].lanes[lane].timC); channel, slotrank, lane, rn.start, rn.middle, rn.end);
} }
return 0; return 0;
} }
@@ -1847,9 +1839,6 @@ static int discover_timB(ramctr_timing *ctrl, int channel, int slotrank)
(DEFAULT_MCHBAR + lane_registers[lane] + (DEFAULT_MCHBAR + lane_registers[lane] +
channel * 0x100 + 4 + ((timB / 32) & 1) * 4) channel * 0x100 + 4 + ((timB / 32) & 1) * 4)
>> (timB % 32)) & 1); >> (timB % 32)) & 1);
printram("Bstat: %d, %d, %d: %x, %x\n",
channel, slotrank, lane, timB,
statistics[lane][timB]);
} }
} }
FOR_ALL_LANES { FOR_ALL_LANES {
@@ -1873,8 +1862,8 @@ static int discover_timB(ramctr_timing *ctrl, int channel, int slotrank)
channel, slotrank, lane); channel, slotrank, lane);
return MAKE_ERR; return MAKE_ERR;
} }
printram("Bval: %d, %d, %d: %x\n", channel, slotrank, printram("timB: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n",
lane, ctrl->timings[channel][slotrank].lanes[lane].timB); channel, slotrank, lane, rn.start, rn.middle, rn.end);
} }
return 0; return 0;
} }
@@ -2218,7 +2207,6 @@ static int test_320c(ramctr_timing * ctrl, int channel, int slotrank)
ctrl->timings[channel][slotrank] = saved_rt; ctrl->timings[channel][slotrank] = saved_rt;
printram("3lanes: %x\n", lanes_ok);
return lanes_ok != ((1 << NUM_LANES) - 1); return lanes_ok != ((1 << NUM_LANES) - 1);
} }
@@ -2355,9 +2343,6 @@ static int try_cmd_stretch(ramctr_timing *ctrl, int channel, int cmd_stretch)
FOR_ALL_POPULATED_RANKS { FOR_ALL_POPULATED_RANKS {
stat[slotrank][c320c + 127] = stat[slotrank][c320c + 127] =
test_320c(ctrl, channel, slotrank); test_320c(ctrl, channel, slotrank);
printram("3stat: %d, %d, %d: %x\n",
channel, slotrank, c320c,
stat[slotrank][c320c + 127]);
} }
} }
FOR_ALL_POPULATED_RANKS { FOR_ALL_POPULATED_RANKS {
@@ -2365,9 +2350,8 @@ static int try_cmd_stretch(ramctr_timing *ctrl, int channel, int cmd_stretch)
get_longest_zero_run(stat[slotrank], 255); get_longest_zero_run(stat[slotrank], 255);
ctrl->timings[channel][slotrank].val_320c = ctrl->timings[channel][slotrank].val_320c =
rn.middle - 127; rn.middle - 127;
printram("3val %d, %d: %d\n", channel, printram("cmd_stretch: %d, %d: 0x%02x-0x%02x-0x%02x\n",
slotrank, channel, slotrank, rn.start, rn.middle, rn.end);
ctrl->timings[channel][slotrank].val_320c);
if (rn.all || rn.length < MIN_C320C_LEN) { if (rn.all || rn.length < MIN_C320C_LEN) {
FOR_ALL_POPULATED_RANKS { FOR_ALL_POPULATED_RANKS {
ctrl->timings[channel][slotrank] = ctrl->timings[channel][slotrank] =