sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/lib: Clean up general issues found by checkpatch.pl

Browse Source 
Fix the following errors and warnings detected by checkpatch.pl:

ERROR: Bad function definition - void init_timer() should probably be void init_timer(void)
ERROR: Prefixing 0x with decimal output is defective
WARNING: Comparisons should place the constant on the right side of the test
WARNING: char * array declaration might be better as static const

TEST=Build and run on Galileo Gen2

Change-Id: I9f618eea95e1f92fa34f4f89da27c0b16ae7f4ee
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18763
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Lee Leahy
2017-03-10 17:56:44 -08:00
parent 491c5b60d0
commit 36984d85e7
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/reg_script.c
View File

@@ -476,7 +476,7 @@ static uint64_t reg_script_read(struct reg_script_context *ctx)
/* Read from the platform specific bus */
bus = find_bus(step);
if (NULL != bus) {
if (bus != NULL) {
value = bus->reg_script_read(ctx);
break;
}
@@ -530,7 +530,7 @@ static void reg_script_write(struct reg_script_context *ctx)
/* Write to the platform specific bus */
bus = find_bus(step);
if (NULL != bus) {
if (bus != NULL) {
bus->reg_script_write(ctx);
break;
}