sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/acpi/pm_state: don't rely on undefined behavior

Browse Source 
Change-Id: I5a76a38f8d84666f6b9c0bfffecca064fa82d593
Found-by: Coverity CID 1445994
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50492
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held
2021-02-10 18:57:04 +01:00
parent 5dd52c77f7
commit 373769f103
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/block/acpi/pm_state.c
View File

@@ -18,7 +18,7 @@ static int get_index_bit(uint32_t value, uint16_t limit)
return -1; return -1;
/* get a mask of valid bits. Ex limit = 3, set bits 0-2 */ /* get a mask of valid bits. Ex limit = 3, set bits 0-2 */
t = (1 << limit) - 1; t = (1ULL << limit) - 1;
if ((value & t) == 0) if ((value & t) == 0)
return -1; return -1;
t = 1; t = 1;