sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfs: add struct cbfsf

Browse Source 
Now that cbfs is adding more metadata in the cbfs file
header one needs to access that metadata. Therefore,
add struct cbfsf which tracks the metadata and data
of the file separately. Note that stage and payload
metadata specific to itself is still contained within
the 'data' portion of a cbfs file. Update the cbfs
API to use struct cbfsf. Additionally, remove struct
cbfsd as there's nothing else associated with a cbfs
region aside from offset and size which tracked
by a region_device (thanks, CBFS_ALIGNMENT!).

BUG=None
BRANCH=None
TEST=Built and booted through end of ramstage on qemu armv7.
     Built and booted glados using Chrome OS.

Change-Id: I05486c6cf6cfcafa5c64b36324833b2374f763c2
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/11679
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Aaron Durbin
2015-09-17 16:09:30 -05:00
committed by Patrick Georgi
parent 72bb66eb9c
commit 37a5d15da9
7 changed files with 68 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/common/fsp_ramstage.c
View File

@@ -164,15 +164,15 @@ static void fsp_cache_save(struct prog *fsp)
static int fsp_find_and_relocate(struct prog *fsp)
{
struct region_device fsp_rdev;
struct cbfsf fsp_file;
uint32_t type = CBFS_TYPE_FSP;
if (cbfs_boot_locate(&fsp_rdev, prog_name(fsp), &type)) {
if (cbfs_boot_locate(&fsp_file, prog_name(fsp), &type)) {
printk(BIOS_ERR, "ERROR: Couldn't find fsp.bin in CBFS.\n");
return -1;
}
if (fsp_relocate(fsp, &fsp_rdev)) {
if (fsp_relocate(fsp, &fsp_file.data)) {
printk(BIOS_ERR, "ERROR: FSP relocation failed.\n");
return -1;
}