sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/starlabs/starbook: Fix the ramtop CMOS entry

Browse Source 
The ramtop entry has to be 10 bytes long, and it was incorrectly set
to 10 bits, instead of 10 bytes. Change this to 80.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I506f9d98a389dd859038fd270c5e344b65f514f8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75420
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes
2023-05-25 12:19:42 +01:00
committed by Martin L Roth
parent 83a3b34178
commit 3829b98aeb
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/starlabs/starbook/cmos.layout
View File

@@ -8,6 +8,9 @@ entries
0 120 r 0 reserved_memory
# -----------------------------------------------------------------
# coreboot config options: ramtop
304 80 h 0 ramtop
# RTC_BOOT_BYTE (coreboot hardcoded)
384 1 e 2 boot_option
388 4 h 0 reboot_counter
@@ -44,9 +47,6 @@ entries
# coreboot config options: check sums
984 16 h 0 check_sum
# coreboot config options: ramtop
1000 10 h 0 ramtop
# Bank: 2
# embedded controller settings (outside the checksummed area)
1024 8 h 1 fn_lock_state

6
src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
View File

@@ -8,6 +8,9 @@ entries
0 120 r 0 reserved_memory
# -----------------------------------------------------------------
# coreboot config options: ramtop
304 80 h 0 ramtop
# RTC_BOOT_BYTE (coreboot hardcoded)
384 1 e 2 boot_option
388 4 h 0 reboot_counter
@@ -44,9 +47,6 @@ entries
# coreboot config options: check sums
984 16 h 0 check_sum
# coreboot config options: ramtop
1000 10 h 0 ramtop
# Bank: 2
# embedded controller settings (outside the checksummed area)
1024 8 h 1 fn_lock_state