sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Haswell/falco/peppy/slippy: continue to clean up FUI.

Browse Source 
As a first step towards removing hardcodes from the FUI support,
change the haswell call to i915_lightup to panel_lightup, and pass the
intel_dp * as a parameter. Get rid of the scalar arguments and make
them part of intel_dp. Get rid of file-scope variables and use the
ones in the intel_dp struct. In falco, use functions that peppy
uses. Drop slippy support for FUI, it's a dead board; if this is ok
I'll remove the files next.

And, incidentally, fix the broken RGBX constant and change it to BGRX.

Change-Id: I46ef5a9ed8433382d042066ee3542af04cfc319a
Signed-off-by: Ronald G. Minnich <rminnich@google.com>
Reviewed-on: https://chromium-review.googlesource.com/174932
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Ronald Minnich <rminnich@chromium.org>
Tested-by: Ronald Minnich <rminnich@chromium.org>
(cherry picked from commit 1e1ed410b445c8e2b7411e163d9d6f61499dc3f6)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6833
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
This commit is contained in:
Ronald G. Minnich
2013-10-28 15:01:54 -07:00
committed by Isaac Christensen
parent 2120e0e200
commit 3a75e5e864
9 changed files with 76 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/drivers/intel/gma/i915.h
View File

@@ -175,6 +175,12 @@ struct intel_dp {
struct intel_dp_m_n m_n;
u32 flags;
u32 transcoder;
/* parameters computed by the early startup, to be used
* in the GMA code.
*/
u8 *graphics;
/* physical address, not to be used directly. */
u64 physbase;
};
/* we may yet need these. */
@@ -278,6 +284,7 @@ u32 gtt_read(u32 reg);
int i915lightup(unsigned int physbase, unsigned int mmio,
unsigned int gfx, unsigned int init_fb);
int panel_lightup(struct intel_dp *dp, unsigned int init_fb);
/* display.c */
void compute_display_params(struct intel_dp *dp);