soc/intel/{adl,tgl,jsl}: Enable power button smi after BS_CHIPS_EXIT
On tgl, we noticed system hang if a shutdown is triggered before fsps. The dut is unable to shutdown properly due to tcss is stuck before tcss_init in fsps. This change enable power button smi on jsl, tgl, adl after fsps. it can also prevent a shutdown failure due to lack of fsps init on certain ip. BUG=b:186194102, b:186815114 TEST=Power on the system and pressing power button repeatedly doesn't cause the system hang during shutdown. Change-Id: I70b871f2676a89bc782116e02beba5c20ec51eef Signed-off-by: Kane Chen <kane.chen@intel.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/52874 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
committed by
Patrick Georgi
parent
7b7b33e3a6
commit
3aee3ad46d
@@ -99,10 +99,12 @@ static void post_mp_init(void)
|
||||
cpu_set_max_ratio();
|
||||
|
||||
/*
|
||||
* Now that all APs have been relocated as well as the BSP let SMIs
|
||||
* 1. Now that all APs have been relocated as well as the BSP let SMIs
|
||||
* start flowing.
|
||||
* 2. Skip enabling power button SMI and enable it after BS_CHIPS_INIT
|
||||
* to avoid shutdown hang due to lack of init on certain IP in FSP-S.
|
||||
*/
|
||||
global_smi_enable();
|
||||
global_smi_enable_no_pwrbtn();
|
||||
}
|
||||
|
||||
static const struct mp_ops mp_ops = {
|
||||
|
Reference in New Issue
Block a user