sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel SOC common: Remove unused parameters

Browse Source 
Eliminate unused parameters from the console initialization.

BRANCH=none
BUG=chrome-os-partner:44827
TEST=Build and run on kunimitsu

Original-Change-Id: Iacacea292d43615e9d2f8e5d3ec67e77f3f08906
Original-Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/301204
Original-Commit-Ready: Aaron Durbin <adurbin@chromium.org>
Original-Tested-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

Change-Id: I3a0ea948ce106b07cb6aa872375ce588317dc437
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/11814
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Lee Leahy
2015-09-17 12:35:10 -07:00
committed by Aaron Durbin
parent 13cd3310a5
commit 3c4053fa59
6 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/intel/common/romstage.c
View File

@@ -70,8 +70,8 @@ asmlinkage void *romstage_main(struct cache_as_ram_params *car_params)
memset(&pei_data, 0, sizeof(pei_data));
/* Call into pre-console init code. */
soc_pre_console_init(&params);
mainboard_pre_console_init(&params);
soc_pre_console_init();
mainboard_pre_console_init();
/* Start console drivers */
console_init();
@@ -245,8 +245,7 @@ __attribute__((weak)) void mainboard_check_ec_image(
}
/* Board initialization before the console is enabled */
__attribute__((weak)) void mainboard_pre_console_init(
struct romstage_params *params)
__attribute__((weak)) void mainboard_pre_console_init(void)
{
}
@@ -469,9 +468,8 @@ __attribute__((weak)) void soc_after_temp_ram_exit(void)
}
/* SOC initialization before the console is enabled */
__attribute__((weak)) void soc_pre_console_init(struct romstage_params *params)
__attribute__((weak)) void soc_pre_console_init(void)
{
printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
}
/* SOC initialization before RAM is enabled */

4
src/soc/intel/common/romstage.h
View File

@@ -80,7 +80,7 @@ struct romstage_params {
void mainboard_check_ec_image(struct romstage_params *params);
void mainboard_memory_init_params(struct romstage_params *params,
MEMORY_INIT_UPD *memory_params);
void mainboard_pre_console_init(struct romstage_params *params);
void mainboard_pre_console_init(void);
void mainboard_romstage_entry(struct romstage_params *params);
void mainboard_save_dimm_info(struct romstage_params *params);
void mainboard_add_dimm_info(struct romstage_params *params,
@@ -100,7 +100,7 @@ void soc_display_memory_init_params(const MEMORY_INIT_UPD *old,
MEMORY_INIT_UPD *new);
void soc_memory_init_params(struct romstage_params *params,
MEMORY_INIT_UPD *upd);
void soc_pre_console_init(struct romstage_params *params);
void soc_pre_console_init(void);
void soc_pre_ram_init(struct romstage_params *params);
void soc_romstage_init(struct romstage_params *params);