sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/broadcom: Initialize variable

Browse Source 
It's later tested for NULL, but never initialized to make that test work
reliably.

Change-Id: Iadee1af224507a6dd39956306f3eafa687895176
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1323515
Reviewed-on: https://review.coreboot.org/17880
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Patrick Georgi 2016-12-15 14:59:37 +01:00 committed by Patrick Georgi
parent 6e50e33aea
commit 3d51a6ac99
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/broadcom/secimage/sbi.c
View File

@ -77,12 +77,12 @@ int AddImagePayload(char *h, char *filename, unsigned int filesize)
*---------------------------------------------------------------------*/ *---------------------------------------------------------------------*/
int CreateSecureBootImage(int ac, char **av) int CreateSecureBootImage(int ac, char **av)
{ {
char *outfile, *configfile, *arg, *privkey = NULL, *bl = NULL; char *configfile = NULL, *arg, *privkey = NULL, *bl = NULL;
int status = 0; int status = 0;
uint32_t sbiLen; uint32_t sbiLen;
struct stat file_stat; struct stat file_stat;
uint32_t add_header = 1; uint32_t add_header = 1;
outfile = *av; char *outfile = *av;
unsigned int filesize; unsigned int filesize;
char *buf; char *buf;
--ac; ++av; --ac; ++av;