cbfstool: Fix leak in cbfs_image struct initialization
This patches a memory leak on every struct cbfs_image creation that
was introduced by c1d1fd850e
. Since that
commit, the CBFS master header has been copied to a separate buffer so
that its endianness could be fixed all at once; unfortunately, this
buffer was malloc()'d but never free()'d. To address the issue, we
replace the structure's struct cbfs_header * with a struct cbfs_header
to eliminate the additional allocation.
Change-Id: Ie066c6d4b80ad452b366a2a95092ed45aa55d91f
Signed-off-by: Sol Boucher <solb@chromium.org>
Reviewed-on: http://review.coreboot.org/10130
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
committed by
Patrick Georgi
parent
297c88c357
commit
3e060ed112
@@ -465,7 +465,7 @@ static int cbfs_locate(void)
|
||||
}
|
||||
|
||||
if (param.top_aligned)
|
||||
address = address - image.header->romsize;
|
||||
address = address - image.header.romsize;
|
||||
|
||||
cbfs_image_delete(&image);
|
||||
printf("0x%x\n", address);
|
||||
|
Reference in New Issue
Block a user