sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/variant/hades: Reduce PEXVDD shutoff delay for Hades

Browse Source 
For the sequenced controlled shutdown path, there's a 10ms delay
after the PEXVDD rail is disabled to permit discharge needed on
Agah/Proxima.

This can be dropped to 3ms for Hades designs Proto0 and forward.

Once Agah board is dropped, "if CONFIG" can be cleaned up/removed.

BUG=b:271167335
TEST=builds
Signed-off-by: Tarun Tuli <taruntuli@google.com>

Change-Id: I8a0d62ec76caff861adce2d6c0ba2d4e4064affa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75051
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Tarun Tuli
2023-05-09 13:00:26 +00:00
committed by Felix Held
parent 7ad8b0987a
commit 3e304e5257
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/brya/acpi/power.asl
View File

@@ -131,7 +131,11 @@ Method (GC6I, 0, Serialized)
/* Ramp down PEXVDD */ /* Ramp down PEXVDD */
CTXS (GPIO_PEXVDD_PWR_EN) CTXS (GPIO_PEXVDD_PWR_EN)
GPPL (GPIO_PEXVDD_PG, 0, 20) GPPL (GPIO_PEXVDD_PG, 0, 20)
#if CONFIG(BOARD_GOOGLE_AGAH)
Sleep (10) Sleep (10)
#else
Sleep (3)
#endif
/* Deassert EN_PPVAR_GPU_NVVDD */ /* Deassert EN_PPVAR_GPU_NVVDD */
CTXS (GPIO_NVVDD_PWR_EN) CTXS (GPIO_NVVDD_PWR_EN)
@@ -272,7 +276,11 @@ Method (PGOF, 0, Serialized)
/* Ramp down PEXVDD and let rail discharge to <10% */ /* Ramp down PEXVDD and let rail discharge to <10% */
CTXS (GPIO_PEXVDD_PWR_EN) CTXS (GPIO_PEXVDD_PWR_EN)
GPPL (GPIO_PEXVDD_PG, 0, 20) GPPL (GPIO_PEXVDD_PG, 0, 20)
#if CONFIG(BOARD_GOOGLE_AGAH)
Sleep (10) Sleep (10)
#else
Sleep (3)
#endif
/* Ramp down NVVDD and let rail discharge to <10% */ /* Ramp down NVVDD and let rail discharge to <10% */
CTXS (GPIO_NVVDD_PWR_EN) CTXS (GPIO_NVVDD_PWR_EN)

2
src/mainboard/google/brya/variants/hades/variant.c
View File

@@ -61,7 +61,7 @@ static struct power_rail_sequence gpu_on_seq[] = {
/* In GCOFF entry order (i.e., power-off order) */ /* In GCOFF entry order (i.e., power-off order) */
static struct power_rail_sequence gpu_off_seq[] = { static struct power_rail_sequence gpu_off_seq[] = {
{ "FBVDD", FBVDD_PWR_EN, false, FBVDD_PG, 0,}, { "FBVDD", FBVDD_PWR_EN, false, FBVDD_PG, 0,},
{ "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 10,}, { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 3,},
{ "NVVDD+MSVDD", NVVDD_PWR_EN, false, NVVDD_PG, 2,}, { "NVVDD+MSVDD", NVVDD_PWR_EN, false, NVVDD_PG, 2,},
{ "GPU 3.3V", GPU_3V3_PWR_EN, false, GPU_3V3_PG, 4,}, { "GPU 3.3V", GPU_3V3_PWR_EN, false, GPU_3V3_PG, 4,},
{ "GPU 1.8V", GPU_1V8_PWR_EN, false, GPU_1V8_PG, 0,}, { "GPU 1.8V", GPU_1V8_PWR_EN, false, GPU_1V8_PG, 0,},