From 403fa86924157b5fd73365b41803698602a168a1 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Mon, 26 Jul 2021 22:43:00 +0200 Subject: [PATCH] include/acpi/acpi.h: add comment about raw data in generic error status Since the specification isn't very clear on this, add a comment about the optional raw data part of a acpi_generic_error_status block. Signed-off-by: Felix Held Change-Id: I6df7d2f216fe0515e89d08c8ed01f06d19461429 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56611 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- src/include/acpi/acpi.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 7a6e9112ab..01d10c2b20 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -929,7 +929,15 @@ typedef struct acpi_hest_generic_data_v300 { #define ACPI_GENERROR_VALID_FRUID_TEXT BIT(1) #define ACPI_GENERROR_VALID_TIMESTAMP BIT(2) -/* Generic Error Status Block */ +/* + * Generic Error Status Block + * + * If there is a raw data section at the end of the generic error status block after the + * zero or more generic error data entries, raw_data_length indicates the length of the raw + * section and raw_data_offset is the offset of the beginning of the raw data section from + * the start of the acpi_generic_error_status block it is contained in. So if raw_data_length + * is non-zero, raw_data_offset must be at least sizeof(acpi_generic_error_status_t). + */ typedef struct acpi_generic_error_status { u32 block_status; u32 raw_data_offset; /* must follow any generic entries */