sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbtable: remove chromeos_acpi from cbtable

Browse Source 
Since we can derive chromeos_acpi's location from that of
ACPI GNVS, remove chromeos_acpi entry from cbtable and
instead use acpi_gnvs + GVNS_CHROMEOS_ACPI_OFFSET.

BUG=b:112288216
TEST=None
CQ-DEPEND=CL:1179725

Change-Id: I74d8a9965a0ed7874ff03884e7a921fd725eace9
Signed-off-by: Joel Kitching <kitching@google.com>
Reviewed-on: https://review.coreboot.org/28190
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Joel Kitching
2018-08-17 15:38:59 +08:00
committed by Martin Roth
parent 5846d5727a
commit 44cff7a897
23 changed files with 24 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/lib/coreboot_table.c
View File

@ -195,19 +195,6 @@ static void lb_gpios(struct lb_header *header)
}
}
static void lb_chromeos_acpi(struct lb_header *header)
{
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
struct lb_range *chromeos_acpi;
chromeos_acpi = (struct lb_range *)lb_new_record(header);
chromeos_acpi->tag = LB_TAG_CHROMEOS_ACPI;
chromeos_acpi->size = sizeof(*chromeos_acpi);
acpi_get_chromeos_acpi_info(&chromeos_acpi->range_start,
&chromeos_acpi->range_size);
#endif
}
static void lb_vbnv(struct lb_header *header)
{
#if IS_ENABLED(CONFIG_PC80_SYSTEM)
@ -547,9 +534,6 @@ static uintptr_t write_coreboot_table(uintptr_t rom_table_end)
/* Record our GPIO settings (ChromeOS specific) */
lb_gpios(head);
/* pass along the chromeos_acpi_t buffer address */
lb_chromeos_acpi(head);
/* pass along VBNV offsets in CMOS */
lb_vbnv(head);