sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/starlabs: Correct Keyboard Backlight offsets for GLK

Browse Source 
Correct the offsets used for the keyboard backlight control:
    ECRAM_KBL_STATE         0x19
    ECRAM_KBL_BRIGHTNESS    0x18

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I23bac43301635e6b18f1cbd28311e7210b049c70
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62126
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Andy Pont <andy.pont@sdcsystems.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Sean Rhodes
2022-02-17 14:24:03 +00:00
committed by Felix Held
parent 7dea2e5548
commit 45041caaba
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ec/starlabs/merlin/variants/glk/ecdefs.h
View File

@@ -15,8 +15,8 @@
/* EC RAM offsets. */ /* EC RAM offsets. */
#define ECRAM_TRACKPAD_STATE 0x14 #define ECRAM_TRACKPAD_STATE 0x14
#define ECRAM_KBL_STATE 0x18 #define ECRAM_KBL_STATE 0x19
#define ECRAM_KBL_BRIGHTNESS 0x19 #define ECRAM_KBL_BRIGHTNESS 0x18
#define ECRAM_KBL_TIMEOUT 0x1a #define ECRAM_KBL_TIMEOUT 0x1a
#define ECRAM_FN_LOCK_STATE 0x2c #define ECRAM_FN_LOCK_STATE 0x2c
#define ECRAM_FN_CTRL_REVERSE 0x2d #define ECRAM_FN_CTRL_REVERSE 0x2d

2
src/ec/starlabs/merlin/variants/glk/emem.asl
View File

@@ -20,8 +20,8 @@ Field (ECF2, ByteAcc, Lock, Preserve)
AFG3, 8, // After G3 AFG3, 8, // After G3
CLTP, 8, // Close Trackpad CLTP, 8, // Close Trackpad
WKOL, 8, // Wake on Lid WKOL, 8, // Wake on Lid
KLSE, 8, // Keyboard Backlight State
KLBE, 8, // Keyboard Backlight Brightness KLBE, 8, // Keyboard Backlight Brightness
KLSE, 8, // Keyboard Backlight State
Offset(0x1a), Offset(0x1a),
KLTE, 8, // Keyboard Backlight Timeout KLTE, 8, // Keyboard Backlight Timeout