sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/corsola: Use function to get regulator IDs

Browse Source 
There might be inconsistence between regulator_id[] and
`enum mtk_regulator` when we need to add new regulator IDs for Geralt.
Therefore, we implement get_mt6366_regulator_id() to get regulator IDs.

BUG=None
TEST=build pass.

Change-Id: I3d28ebf2affe4e9464b1a7c1fb2bbb9e31d64a5e
Signed-off-by: Liju-Clr Chen <liju-clr.chen@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72838
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
This commit is contained in:
Liju-Clr Chen 2023-02-06 16:21:05 +08:00 committed by Felix Held
parent 6f375320c3
commit 45d51a92ee
1 changed files with 34 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
src/mainboard/google/corsola/regulator.c
View File

@ -5,45 +5,54 @@
#include <soc/mt6366.h> #include <soc/mt6366.h>
#include <soc/regulator.h> #include <soc/regulator.h>
#define REGULATOR_NOT_SUPPORT -1 #define MTK_REGULATOR_INVALID -1
static const int regulator_id[] = { static int get_mt6366_regulator_id(enum mtk_regulator regulator)
[MTK_REGULATOR_VDD1] = REGULATOR_NOT_SUPPORT, {
[MTK_REGULATOR_VDD2] = REGULATOR_NOT_SUPPORT, switch (regulator) {
[MTK_REGULATOR_VDDQ] = MT6366_VDDQ, case MTK_REGULATOR_VDDQ:
[MTK_REGULATOR_VMDDR] = REGULATOR_NOT_SUPPORT, return MT6366_VDDQ;
[MTK_REGULATOR_VCORE] = MT6366_VCORE, case MTK_REGULATOR_VCORE:
[MTK_REGULATOR_VCC] = REGULATOR_NOT_SUPPORT, return MT6366_VCORE;
[MTK_REGULATOR_VCCQ] = REGULATOR_NOT_SUPPORT, case MTK_REGULATOR_VDRAM1:
[MTK_REGULATOR_VDRAM1] = MT6366_VDRAM1, return MT6366_VDRAM1;
[MTK_REGULATOR_VMCH] = MT6366_VMCH, case MTK_REGULATOR_VMCH:
[MTK_REGULATOR_VMC] = MT6366_VMC, return MT6366_VMCH;
[MTK_REGULATOR_VPROC12] = MT6366_VPROC12, case MTK_REGULATOR_VMC:
[MTK_REGULATOR_VSRAM_PROC12] = MT6366_VSRAM_PROC12, return MT6366_VMC;
[MTK_REGULATOR_VRF12] = MT6366_VRF12, case MTK_REGULATOR_VPROC12:
[MTK_REGULATOR_VCN33] = MT6366_VCN33, return MT6366_VPROC12;
}; case MTK_REGULATOR_VSRAM_PROC12:
return MT6366_VSRAM_PROC12;
_Static_assert(ARRAY_SIZE(regulator_id) == MTK_REGULATOR_NUM, "regulator_id size error"); case MTK_REGULATOR_VRF12:
return MT6366_VRF12;
case MTK_REGULATOR_VCN33:
return MT6366_VCN33;
default:
return MTK_REGULATOR_INVALID;
}
}
void mainboard_set_regulator_voltage(enum mtk_regulator regulator, uint32_t voltage_uv) void mainboard_set_regulator_voltage(enum mtk_regulator regulator, uint32_t voltage_uv)
{ {
assert(regulator < MTK_REGULATOR_NUM); int id;
if (regulator_id[regulator] < 0) { id = get_mt6366_regulator_id(regulator);
if (id < 0) {
printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator); printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator);
return; return;
} }
mt6366_set_voltage(regulator_id[regulator], voltage_uv); mt6366_set_voltage(id, voltage_uv);
} }
uint32_t mainboard_get_regulator_voltage(enum mtk_regulator regulator) uint32_t mainboard_get_regulator_voltage(enum mtk_regulator regulator)
{ {
assert(regulator < MTK_REGULATOR_NUM); int id;
if (regulator_id[regulator] < 0) { id = get_mt6366_regulator_id(regulator);
if (id < 0) {
printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator); printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator);
return 0; return 0;
} }
return mt6366_get_voltage(regulator_id[regulator]); return mt6366_get_voltage(id);
} }