sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add -Werror to help us keep the code clean.

Browse Source 
Change sizes from unsigned int to int.
Clean up some usage and parameter checking.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4262 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Myles Watson
2009-05-08 19:39:15 +00:00
parent 83b8f0c485
commit 475aeda9d6
10 changed files with 37 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
util/cbfstool/create.c
View File

@@ -24,7 +24,7 @@
void create_usage(void)
{
printf("create SIZE BOOTBLOCKSIZE [ALIGN] [BOOTBLOCK]\tCreate a ROM file\n");
printf("create SIZE BOOTBLOCKSIZE BOOTBLOCK [ALIGN]\tCreate a ROM file\n");
}
int create_handler(struct rom *rom, int argc, char **argv)
@@ -33,7 +33,7 @@ int create_handler(struct rom *rom, int argc, char **argv)
char *bootblock = NULL;
int bootblocksize;
if (argc < 2) {
if (argc < 3) {
create_usage();
return -1;
}
@@ -42,11 +42,10 @@ int create_handler(struct rom *rom, int argc, char **argv)
bootblocksize = get_size(argv[1]);
if (argc == 3) {
bootblock = argv[2];
} else if (argc >= 4) {
align = strtoul(argv[2], NULL, 0);
bootblock = argv[3];
bootblock = argv[2];
if (argc >= 4) {
align = strtoul(argv[3], NULL, 0);
}
if (size < bootblocksize) {