sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/{razer,purism}: Don't select NO_POST

Browse Source 
The NO_POST option covers more than classical port 80 output, hence
selecting it seems wrong in any case. The default is still rather
user patronizing, but let's keep it.

As a side effect, this fixes the ability to override the default
for NO_POST which Kconfig rejected while these boards selected it.
(Seems like a bug in Kconfig, though.)

Change-Id: I896b08812b1aa6ce249d7acc8073ebcc0f72eace
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35956
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Nico Huber
2019-10-10 16:44:29 +02:00
committed by Nico Huber
parent 2437fe9dfa
commit 484ad0f1f7
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/purism/librem_bdw/Kconfig
View File

@@ -7,7 +7,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select INTEL_INT15 select INTEL_INT15
select SOC_INTEL_BROADWELL select SOC_INTEL_BROADWELL
select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_BDW if BOARD_PURISM_BASEBOARD_LIBREM_BDW
@@ -73,5 +72,8 @@ config VGA_BIOS_ID
default "8086,1616" if BOARD_PURISM_LIBREM13_V1 default "8086,1616" if BOARD_PURISM_LIBREM13_V1
default "8086,162b" if BOARD_PURISM_LIBREM15_V2 default "8086,162b" if BOARD_PURISM_LIBREM15_V2
# This platform has limited means to display POST codes
config NO_POST
default y
endif endif

5
src/mainboard/purism/librem_skl/Kconfig
View File

@@ -10,7 +10,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_SKL
select MAINBOARD_USES_FSP2_0 select MAINBOARD_USES_FSP2_0
select SPD_READ_BY_WORD select SPD_READ_BY_WORD
select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_LPC_TPM
select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_SKL if BOARD_PURISM_BASEBOARD_LIBREM_SKL
@@ -68,4 +67,8 @@ config CBFS_SIZE
hex hex
default 0xe00000 default 0xe00000
# This platform has limited means to display POST codes
config NO_POST
default y
endif endif

4
src/mainboard/razer/blade_stealth_kbl/Kconfig
View File

@@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select ADD_FSP_BINARIES select ADD_FSP_BINARIES
select FSP_USE_REPO select FSP_USE_REPO
select NO_POST
# For now no way to choose the correct the available RAM # For now no way to choose the correct the available RAM
config BOARD_RAZER_BLADE_STEALTH_KBL_16GB config BOARD_RAZER_BLADE_STEALTH_KBL_16GB
@@ -52,4 +51,7 @@ config BOARD_SPECIFIC_OPTIONS
int int
default 4 default 4
config NO_POST
default y
endif endif