src: Remove redundant use of ACPI offset(0)
IASL version 20180927 and greater, detects Unnecessary/redundant uses of the Offset() operator within a Field Unit list. It then sends a remark "^ Unnecessary/redundant use of Offset" example: OperationRegion (OPR1, SystemMemory, 0x100, 0x100) Field (OPR1) { Offset (0), // Never needed FLD1, 32, Offset (4), // Redundant, offset is already 4 (bytes) FLD2, 8, Offset (64), // OK use of Offset. FLD3, 16, } We will have those remarks: dsdt.asl 14: Offset (0), Remark 2158 - ^ Unnecessary/redundant use of Offset operator dsdt.asl 16: Offset (4), Remark 2158 - ^ Unnecessary/redundant use of Offset operator Change-Id: I260a79ef77025b4befbccc21f5999f89d90c1154 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43283 Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
@@ -29,7 +29,6 @@ Device (EC0)
|
||||
OperationRegion (ERAM, EmbeddedControl, 0x00, 0xFF)
|
||||
Field (ERAM, ByteAcc, NoLock, Preserve)
|
||||
{
|
||||
Offset (0x00),
|
||||
CPUT, 8,
|
||||
}
|
||||
|
||||
|
@@ -12,7 +12,6 @@ Device (EC0)
|
||||
OperationRegion (ERAM, SystemMemory, (CONFIG_EC_BASE_ADDRESS + 0x100), 0x100)
|
||||
Field (ERAM, ByteAcc, Lock, Preserve)
|
||||
{
|
||||
Offset(0x00),
|
||||
, 1,
|
||||
, 1,
|
||||
HKFA, 1, // FN lock (Hotkey / FN row toggle)
|
||||
|
@@ -134,8 +134,7 @@ DefinitionBlock (
|
||||
PIOD, 0x00000008,
|
||||
}
|
||||
IndexField (PIOI, PIOD, ByteAcc, NoLock, Preserve) {
|
||||
Offset(0x00), /* MiscControl */
|
||||
, 1,
|
||||
, 1, /* MiscControl */
|
||||
T1EE, 1,
|
||||
T2EE, 1,
|
||||
Offset(0x01), /* MiscStatus */
|
||||
|
Reference in New Issue
Block a user