sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/bincfg: code cleanup: convert sym_table to a local variable

Browse Source 
Global variables are considered a bad practice.

Change-Id: I652a8da75498f871a53eb7509f6145c4842e3373
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Reviewed-on: https://review.coreboot.org/27810
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Denis 'GNUtoo' Carikli
2018-07-22 16:38:45 +02:00
committed by Patrick Georgi
parent 78d338ccb9
commit 48c24ce5ee
2 changed files with 61 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
util/bincfg/bincfg.h
View File

@@ -37,13 +37,12 @@ struct blob {
unsigned int lenactualblob;
};
static struct field *putsym (char const *, unsigned int);
static struct field *getsym (char const *);
static void yyerror (FILE* fp, char const *);
int yylex (void);
static struct field *putsym(field_ptr_t, char const *, unsigned int);
static struct field *getsym(field_ptr_t, char const *);
static void yyerror(FILE *, field_ptr_t, char const *);
int yylex(void);
static struct blob *binary;
static struct field *sym_table;
static struct field *sym_table_tail;
#endif /* __BINCFG_H */