sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/pi/00670F00: fix #include paths to only use <amdblocks/header.h>

Browse Source 
Ensure that soc/amd/common/blocks/include is the only #include
path for the AMD common code. This removes the duplicate soc/amd/common
include as well using the correct #include header in AGESA.c.

BUG=b:69262110

Change-Id: I50d85b28514fd905df415f0cc052b9924ee4e741
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/22828
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Aaron Durbin
2017-12-12 10:01:06 -07:00
parent 318a03a417
commit 49ec3f0a5f
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/Makefile.inc
View File

@ -1,7 +1,5 @@
ifeq ($(CONFIG_SOC_AMD_COMMON),y) ifeq ($(CONFIG_SOC_AMD_COMMON),y)
CPPFLAGS_common += -I$(src)/soc/amd/common
subdirs-$(CONFIG_SOC_AMD_COMMON_BLOCK) += block subdirs-$(CONFIG_SOC_AMD_COMMON_BLOCK) += block
endif endif

2
src/vendorcode/amd/pi/00670F00/Makefile.inc
View File

@ -50,7 +50,7 @@ AGESA_INC = -I$(obj)
AGESA_INC += $(BINARY_PI_INC) AGESA_INC += $(BINARY_PI_INC)
AGESA_INC += -I$(src)/soc/amd/stoneyridge/include AGESA_INC += -I$(src)/soc/amd/stoneyridge/include
AGESA_INC += -I$(src)/soc/amd/common AGESA_INC += -I$(src)/soc/amd/common/block/include
AGESA_INC += -I$(src)/arch/x86/include AGESA_INC += -I$(src)/arch/x86/include
AGESA_INC += -I$(src)/include AGESA_INC += -I$(src)/include

2
src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
View File

@ -41,7 +41,7 @@
***************************************************************************/ ***************************************************************************/
// TODO This list needs to be pruned of anything that is not API // TODO This list needs to be pruned of anything that is not API
#include "AGESA.h" #include "AGESA.h"
#include <block/include/amdblocks/agesawrapper.h> #include <amdblocks/agesawrapper.h>
#include "AcpiLib.h" #include "AcpiLib.h"
#include "FchCommonCfg.h" #include "FchCommonCfg.h"
#include "Fch.h" #include "Fch.h"