sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel: Fix invalid use of 'static'

Browse Source 
Just keep the variables on the stack.

Change-Id: I36b29d8fb7dac159b29609033cba450bea9adf77
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34326
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Kyösti Mälkki
2019-07-14 05:50:20 +03:00
parent 28dc7dce83
commit 4af4e7f06e
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/purism/librem_skl/hda_verb.c
View File

@@ -40,7 +40,7 @@ static void codecs_init(u8 *base, u32 codec_mask)
static void mb_hda_codec_init(void *unused) static void mb_hda_codec_init(void *unused)
{ {
static struct soc_intel_skylake_config *config; struct soc_intel_skylake_config *config;
u8 *base; u8 *base;
struct resource *res; struct resource *res;
u32 codec_mask; u32 codec_mask;

6
src/soc/intel/apollolake/chip.c
View File

@@ -294,7 +294,7 @@ static void pcie_override_devicetree_after_silicon_init(void)
/* Configure package power limits */ /* Configure package power limits */
static void set_power_limits(void) static void set_power_limits(void)
{ {
static struct soc_intel_apollolake_config *cfg; struct soc_intel_apollolake_config *cfg;
msr_t rapl_msr_reg, limit; msr_t rapl_msr_reg, limit;
uint32_t power_unit; uint32_t power_unit;
uint32_t tdp, min_power, max_power; uint32_t tdp, min_power, max_power;
@@ -361,7 +361,7 @@ static void set_power_limits(void)
/* Overwrites the SCI IRQ if another IRQ number is given by device tree. */ /* Overwrites the SCI IRQ if another IRQ number is given by device tree. */
static void set_sci_irq(void) static void set_sci_irq(void)
{ {
static struct soc_intel_apollolake_config *cfg; struct soc_intel_apollolake_config *cfg;
uint32_t scis; uint32_t scis;
cfg = config_of_path(SA_DEVFN_ROOT); cfg = config_of_path(SA_DEVFN_ROOT);
@@ -666,7 +666,7 @@ void __weak mainboard_devtree_update(struct device *dev)
void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd) void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd)
{ {
FSP_S_CONFIG *silconfig = &silupd->FspsConfig; FSP_S_CONFIG *silconfig = &silupd->FspsConfig;
static struct soc_intel_apollolake_config *cfg; struct soc_intel_apollolake_config *cfg;
struct device *dev; struct device *dev;
/* Load VBT before devicetree-specific config. */ /* Load VBT before devicetree-specific config. */

2
src/soc/intel/skylake/chip_fsp20.c
View File

@@ -232,7 +232,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
{ {
FSP_S_CONFIG *params = &supd->FspsConfig; FSP_S_CONFIG *params = &supd->FspsConfig;
FSP_S_TEST_CONFIG *tconfig = &supd->FspsTestConfig; FSP_S_TEST_CONFIG *tconfig = &supd->FspsTestConfig;
static struct soc_intel_skylake_config *config; struct soc_intel_skylake_config *config;
struct device *dev; struct device *dev;
uintptr_t vbt_data = (uintptr_t)vbt_get(); uintptr_t vbt_data = (uintptr_t)vbt_get();
int i; int i;

2
src/soc/intel/skylake/thermal.c
View File

@@ -62,7 +62,7 @@ static void pch_thermal_set_bar(struct device *dev, uintptr_t tempbar)
/* PCH Low Temp Threshold (LTT) */ /* PCH Low Temp Threshold (LTT) */
static uint16_t pch_get_ltt_value(struct device *dev) static uint16_t pch_get_ltt_value(struct device *dev)
{ {
static struct soc_intel_skylake_config *config; struct soc_intel_skylake_config *config;
uint16_t ltt_value; uint16_t ltt_value;
uint16_t trip_temp = DEFAULT_TRIP_TEMP; uint16_t trip_temp = DEFAULT_TRIP_TEMP;