sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/intel: Fix the remaining issues detected by checkpatch

Browse Source 
Fix the following error and warnings detected by checkpatch.pl:

ERROR: switch and case should be at the same indent
WARNING: Consecutive strings are generally better as a single string
WARNING: static const char * array should probably be static const char * const

TEST=Build and run on Galileo Gen2

Change-Id: I03d5d0d2db0d5e9b33c8ec807b236fe229bcc8f3
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18851
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Lee Leahy 2017-03-15 18:31:03 -07:00
parent cdc50480c4
commit 4dddda294f
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/cpu/intel/speedstep/acpi.c
View File

@ -50,13 +50,13 @@ static int get_fsb(void)
{ {
const u32 fsbcode = rdmsr(MSR_FSB_FREQ).lo & 7; const u32 fsbcode = rdmsr(MSR_FSB_FREQ).lo & 7;
switch (fsbcode) { switch (fsbcode) {
case 0: return 800; /* / 3 == 266 */ case 0: return 800; /* / 3 == 266 */
case 1: return 400; /* / 3 == 133 */ case 1: return 400; /* / 3 == 133 */
case 2: return 600; /* / 3 == 200 */ case 2: return 600; /* / 3 == 200 */
case 3: return 500; /* / 3 == 166 */ case 3: return 500; /* / 3 == 166 */
case 4: return 1000; /* / 3 == 333 */ case 4: return 1000; /* / 3 == 333 */
case 5: return 300; /* / 3 == 100 */ case 5: return 300; /* / 3 == 100 */
case 6: return 1200; /* / 3 == 400 */ case 6: return 1200; /* / 3 == 400 */
} }
printk(BIOS_WARNING, printk(BIOS_WARNING,
"Warning: No supported FSB frequency. Assuming 200MHz\n"); "Warning: No supported FSB frequency. Assuming 200MHz\n");
@ -84,8 +84,8 @@ static void gen_pstate_entries(const sst_table_t *const pstates,
/ (pstates->states[pstates->num_states - 1].is_slfm ? 12 : 6), / (pstates->states[pstates->num_states - 1].is_slfm ? 12 : 6),
(max_ratio2 * fsb3) / 6); (max_ratio2 * fsb3) / 6);
printk(BIOS_DEBUG, "adding %x P-States between " printk(BIOS_DEBUG,
"busratio %x and %x, ""incl. P0\n", "adding %x P-States between busratio %x and %x, incl. P0\n",
pstates->num_states, min_ratio2 / 2, max_ratio2 / 2); pstates->num_states, min_ratio2 / 2, max_ratio2 / 2);
acpigen_write_package(pstates->num_states); acpigen_write_package(pstates->num_states);
for (i = 0; i < pstates->num_states; ++i) { for (i = 0; i < pstates->num_states; ++i) {

2
src/cpu/intel/turbo/turbo.c
View File

@ -42,7 +42,7 @@ static inline void set_global_turbo_state(int state)
} }
#endif #endif
static const char *turbo_state_desc[] = { static const char * const turbo_state_desc[] = {
[TURBO_UNKNOWN] = "unknown", [TURBO_UNKNOWN] = "unknown",
[TURBO_UNAVAILABLE] = "unavailable", [TURBO_UNAVAILABLE] = "unavailable",
[TURBO_DISABLED] = "available but hidden", [TURBO_DISABLED] = "available but hidden",