sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/*: drop useless XTAL shutdown qualification code

Browse Source 
The XTAL shutdown (dis)qualification bit already unconditionally gets
set to 1 by FSP for these platforms, making this code redundant.

Change-Id: I7fa4afb0de2af1814e5b91c152d82d7ead310338
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46016
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Michael Niewöhner
2020-10-04 14:34:41 +02:00
committed by Patrick Georgi
parent 4b6ff98e84
commit 4e8baf9202
9 changed files with 5 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/soc/intel/cannonlake/finalize.c
View File

@ -73,16 +73,11 @@ static void pch_finalize(void)
if (config->PmTimerDisabled)
pmc_disable_acpi_timer();
if (config->s0ix_enable) {
/* Disable XTAL shutdown qualification for low power idle. */
pmc_ignore_xtal_shutdown();
if (config->cppmvric2_adsposcdis) {
/* Enable Audio DSP OSC qualification for S0ix */
reg32 = read32(pmcbase + CPPMVRIC2);
reg32 &= ~ADSPOSCDIS;
write32(pmcbase + CPPMVRIC2, reg32);
}
if (config->s0ix_enable && config->cppmvric2_adsposcdis) {
/* Enable Audio DSP OSC qualification for S0ix */
reg32 = read32(pmcbase + CPPMVRIC2);
reg32 &= ~ADSPOSCDIS;
write32(pmcbase + CPPMVRIC2, reg32);
}
pch_handle_sideband(config);