ChromeOS: Promote variant_cros_gpio()

The only purpose of mainboard_chromeos_acpi_generate()
was to pass cros_gpio array for ACPI \\OIPG package
generation.

Promote variant_cros_gpio() from baseboards to ChromeOS
declaration.

Change-Id: I5c2ac1dcea35f1f00dea401528404bc6ca0ab53c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58897
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Kyösti Mälkki
2021-11-02 10:36:20 +02:00
committed by Felix Held
parent afe5562ca3
commit 4fdd84e716
70 changed files with 97 additions and 321 deletions

View File

@ -6,11 +6,16 @@
#endif
#include "chromeos.h"
void chromeos_acpi_gpio_generate(const struct cros_gpio *gpios, size_t num)
void chromeos_acpi_gpio_generate(void)
{
size_t i;
const struct cros_gpio *gpios;
size_t i, num;
int gpio_num;
gpios = variant_cros_gpios(&num);
if (!gpios)
return;
acpigen_write_scope("\\");
acpigen_write_name("OIPG");

View File

@ -37,17 +37,10 @@ void chromeos_init_chromeos_acpi(void);
*/
enum cb_err get_dsm_calibration_from_key(const char *key, uint64_t *value);
/*
* Create the OIPG package containing the Chrome OS gpios described by
* the chromeos_gpio array.
*/
struct cros_gpio;
void chromeos_acpi_gpio_generate(const struct cros_gpio *gpios, size_t num);
/*
* Declaration for mainboards to use to generate ACPI-specific Chrome OS needs.
*/
void mainboard_chromeos_acpi_generate(void);
void chromeos_acpi_gpio_generate(void);
enum {
CROS_GPIO_REC = 1, /* Recovery */
@ -104,4 +97,6 @@ struct cros_gpio {
#define CROS_GPIO_PE_AH(num, dev) \
CROS_GPIO_PE_INITIALIZER(CROS_GPIO_ACTIVE_HIGH, num, dev)
const struct cros_gpio *variant_cros_gpios(size_t *num);
#endif /* __CHROMEOS_H__ */

View File

@ -98,6 +98,5 @@ void acpi_fill_cnvs(void)
acpigen_write_opregion(&cnvs_op);
acpigen_pop_len();
/* Usually this creates OIPG package for GPIOs. */
mainboard_chromeos_acpi_generate();
chromeos_acpi_gpio_generate();
}