sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/system76: Add console support

Browse Source 
This adds support for line-buffered console output to System76 EC firmware.

Once the print command is received, the EC firmware multiplexes the output
to any enabled console on the EC. This can be a memory ringbuffer, a
parallel port (using the keyboard connector), or i2c (using the battery
connector). Once the entire buffer is sent, it sets the command register
to 0, indicating completion. For more information, please see:
https://github.com/system76/ec/blob/master/doc/debugging.md

Tested on system76/lemp9 with CONSOLE_SYSTEM76_EC enabled.

Signed-off-by: Jeremy Soller <jeremy@system76.com>
Change-Id: I861bf3e22f40dd6c3ec7ba1d73711b399358e332
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43718
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner
This commit is contained in:
Jeremy Soller
2020-07-22 06:40:28 -06:00
committed by Michael Niewöhner
parent 7e396f380e
commit 52785ab327
5 changed files with 113 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/console/Kconfig
View File

@ -302,6 +302,13 @@ config SPI_CONSOLE
This is currently working only in ramstage due to how the spi
drivers are written.
config CONSOLE_SYSTEM76_EC
bool "System76 EC console output"
default n
depends on EC_SYSTEM76_EC
help
Send coreboot debug output to a System76 embedded controller.
config CONSOLE_OVERRIDE_LOGLEVEL
bool
help

4
src/console/console.c
View File

@ -9,6 +9,7 @@
#include <console/usb.h>
#include <console/spi.h>
#include <console/flash.h>
#include <console/system76_ec.h>
void console_hw_init(void)
{
@ -21,6 +22,7 @@ void console_hw_init(void)
__usbdebug_init();
__spiconsole_init();
__flashconsole_init();
__system76_ec_init();
}
void console_tx_byte(unsigned char byte)
@ -42,6 +44,7 @@ void console_tx_byte(unsigned char byte)
__usb_tx_byte(byte);
__spiconsole_tx_byte(byte);
__flashconsole_tx_byte(byte);
__system76_ec_tx_byte(byte);
}
void console_tx_flush(void)
@ -50,6 +53,7 @@ void console_tx_flush(void)
__ne2k_tx_flush();
__usb_tx_flush();
__flashconsole_tx_flush();
__system76_ec_tx_flush();
}
void console_write_line(uint8_t *buffer, size_t number_of_bytes)