sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/i2c/tpm: Fix issues detected by checkpatch

Browse Source 
Fix the following warnings detected by checkpatch.pl:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
WARNING: braces {} are not necessary for single statement blocks
WARNING: Unnecessary parentheses - maybe == should be = ?
WARNING: line over 80 characters
WARNING: missing space after return type

TEST=Build and run on Galileo Gen2

Change-Id: I56f915f6c1975cce123fd38043bad2638717d88c
Signed-off-by: Lee Leahy <leroy.p.leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18832
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Lee Leahy
2017-03-15 09:22:11 -07:00
parent 08824ec8d4
commit 52ab30b13b
5 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/i2c/tpm/tis.c
View File

@@ -47,9 +47,8 @@ int tis_open(void)
if (rc < 0)
chip->is_open = 0;
if (rc) {
if (rc)
return -1;
}
return 0;
}
@@ -115,8 +114,9 @@ static ssize_t tpm_transmit(const uint8_t *buf, size_t bufsiz)
goto out_recv;
}
if ((status == chip->vendor.req_canceled)) {
printk(BIOS_DEBUG, "tpm_transmit: Operation Canceled\n");
if (status == chip->vendor.req_canceled) {
printk(BIOS_DEBUG,
"tpm_transmit: Operation Canceled\n");
rc = -1;
goto out;
}