sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86: Remove unnecessary guard

Browse Source 
The is_smm_enabled is not necessary because it is done previously
in this code path.

Signed-off-by: Eugene D. Myers <edmyers@tycho.nsa.gov>
Change-Id: I20d50acbea891cb56ad49edc128df25d21c5f1ca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38820
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Eugene Myers
2020-02-10 15:44:38 -05:00
committed by Patrick Georgi
parent 970ed2ad29
commit 53e92360f5
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/cpu/x86/mp_init.c
View File

@ -747,20 +747,15 @@ static void asmlinkage smm_do_relocation(void *arg)
mp_state.ops.relocation_handler(cpu, curr_smbase, perm_smbase); mp_state.ops.relocation_handler(cpu, curr_smbase, perm_smbase);
if (CONFIG(STM)) { if (CONFIG(STM)) {
if (is_smm_enabled()) { uintptr_t mseg;
uintptr_t mseg;
mseg = mp_state.perm_smbase + mseg = mp_state.perm_smbase +
(mp_state.perm_smsize - CONFIG_MSEG_SIZE); (mp_state.perm_smsize - CONFIG_MSEG_SIZE);
stm_setup(mseg, p->cpu, runtime->num_cpus, stm_setup(mseg, p->cpu, runtime->num_cpus,
perm_smbase, perm_smbase,
mp_state.perm_smbase, mp_state.perm_smbase,
runtime->start32_offset); runtime->start32_offset);
} else {
printk(BIOS_DEBUG,
"STM not loaded because SMM is not enabled!\n");
}
} }
} }