From 566623f0fc7d2e174ae10a53c024dbd1a15282e0 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 30 Aug 2023 13:14:21 +0100 Subject: [PATCH] soc/intel/alderlake: Sync UPD Usb4CmMode with Kconfig The ACPI is adjusted based on SOFTWARE_CONNECTION_MANAGER, so set the UPD to match this to avoid the connection type being mismatched. If it's mismatched, the TBT port will time out. Signed-off-by: Sean Rhodes Change-Id: I8a99db165301ce08caf55aac0e33ca1994559d62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80486 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Kapil Porwal --- src/soc/intel/alderlake/fsp_params.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index c45cbf8c11..847f1e31a1 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -680,6 +680,10 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg, if (is_dev_enabled(tcss_port_arr[i])) s_cfg->UsbTcPortEn |= BIT(i); } + +#if !CONFIG(SOC_INTEL_ALDERLAKE_PCH_M) + s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER); +#endif } static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg,