sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD AGESA: Add missing breaks to switch statement in one file

Browse Source 
This is the same patch as an earlier one applied to family 15 [1].

Static analysis often flags case statements that do not include
a terminating "break;" statement. Eclipse's CODAN is an example
of this.  This changelist modifies amdlib.c to terminate
case statements with "break;".

[1] e44a89f amd/agesa/f15/Lib/amdlib.c: Add missing breaks ...

Change-Id: Ibd1ae6f2b52fde07de3d978d174975f4d93647ab
Signed-off-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
Reviewed-on: http://review.coreboot.org/3839
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martin@se-eng.com>
This commit is contained in:
Bruce Griffith 2013-06-25 14:14:14 -06:00
parent ee7cd8d85d
commit 5697df2a84
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/vendorcode/amd/agesa/f16kb/Lib/amdlib.c
View File

@ -297,6 +297,7 @@ LibAmdReadCpuReg (
break;
default:
*Value = -1;
break;
}
}
VOID
@ -325,7 +326,7 @@ LibAmdWriteCpuReg (
__writedr (7, Value);
break;
default:
;
break;
}
}
VOID
@ -504,6 +505,7 @@ LibAmdIoRead (
break;
default:
ASSERT (FALSE);
break;
}
}
@ -541,6 +543,7 @@ LibAmdIoWrite (
break;
default:
ASSERT (FALSE);
break;
}
}
@ -641,6 +644,7 @@ LibAmdMemRead (
break;
default:
ASSERT (FALSE);
break;
}
}
@ -679,6 +683,7 @@ LibAmdMemWrite (
break;
default:
ASSERT (FALSE);
break;
}
}
/*---------------------------------------------------------------------------------------*/
@ -1297,6 +1302,7 @@ LibAmdGetDataFromPtr (
break;
default:
IDS_ERROR_TRAP;
break;
}
}
@ -1336,6 +1342,7 @@ LibAmdAccessWidth (
default:
Width = 0;
IDS_ERROR_TRAP;
break;
}
return Width;
}