From 56c3444d85a1b60fcc891910c9c60e5f75ba9197 Mon Sep 17 00:00:00 2001 From: Nicholas Chin Date: Fri, 8 Mar 2024 07:45:09 -0700 Subject: [PATCH] util/docker/Makefile: Create Documentation/_build for docker-build-docs If the host directory of a bind mount does not exist, Docker will create it. However, the newly created directory will be owned by root due to the Docker service running within a root context. The docker command in the recipe for docker-build-docs binds Documentation/_build to /data-out within the container, so if it doesn't already exist, the documentation builder will be unable to copy the HTML output into /data-out since it runs with the same UID and GID as the host user. By creating, if necessary, the _build directory before the `docker run` command, there should always be an existing directory owned by the host user for docker to bind /data-out to (ignoring the case of an existing _build directory the current user does not have permission to write to), avoiding the issue where it cannot write the output. TEST: make -C util/docker docker-build-docs completes without issues with and without an existing Documentation/_build directory Change-Id: I6be9bc1fdca48f4d924f5c07cc261189ab6862fd Signed-off-by: Nicholas Chin Reviewed-on: https://review.coreboot.org/c/coreboot/+/81127 Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- util/docker/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/util/docker/Makefile b/util/docker/Makefile index 77526bba5e..45562d7a7b 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -177,6 +177,7 @@ docker-jenkins-attach: test-docker docker-build-docs: test-docker docker-build-docs: + mkdir -p $(top)/Documentation/_build $(DOCKER) run -it --rm \ --user $(UID):$(GID) \ -v "$(top)/:/data-in/:ro" \