sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kconfig: Allow KCONFIG_STRICT outside of confdata.c

Browse Source 
To catch dependency errors in symbol.c (such as the ones
fixed by I51b4ee326f082c6a656a813ee5772e9c34f5c343) we need
to check for global kconfig warnings before saving config
files.

This patch will produce errors for wrong dependencies and
add catching of errors to conf, nconf and mconf. Sorry,
gconf users, you will have to wait.

Change-Id: Idf7ee406ce3869941af319219aea16fab826df84
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/11291
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Stefan Reinauer
2015-08-20 11:19:34 -07:00
committed by Patrick Georgi
parent 588ad7b5db
commit 57a31317a2
6 changed files with 34 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
util/kconfig/nconf.c
View File

@@ -646,6 +646,8 @@ static const char *set_config_filename(const char *config_filename)
static int do_exit(void)
{
int res;
char *env;
if (!conf_get_changed()) {
global_exit = 1;
return 0;
@@ -661,6 +663,15 @@ static int do_exit(void)
return -1;
}
env = getenv("KCONFIG_STRICT");
if (env && *env && kconfig_warnings) {
btn_dialog(main_window,
_("\nWarnings encountered, and warnings are errors.\n\n"),
1,
"<OK>");
res = 2;
}
/* if we got here, the user really wants to exit */
switch (res) {
case 0: