From 5ab67f9ef8654ebf51b27441e8f01b9be4553161 Mon Sep 17 00:00:00 2001 From: Jakub Czapiga Date: Mon, 24 May 2021 13:33:07 +0200 Subject: [PATCH] tests/lib/memset-test: Add missing malloc check and free on error Coverity found resource leak in test setup function in error block. Add malloc result check and free in error handling to silence Coverity. Signed-off-by: Jakub Czapiga Found-by: Coverity CID 1446760 Change-Id: Icf746df27167047fa3cf8f5df09fced20863f76d Reviewed-on: https://review.coreboot.org/c/coreboot/+/54874 Tested-by: build bot (Jenkins) Reviewed-by: Paul Fagerburg --- tests/lib/memset-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/lib/memset-test.c b/tests/lib/memset-test.c index 2dde2b349d..7d888a68e1 100644 --- a/tests/lib/memset-test.c +++ b/tests/lib/memset-test.c @@ -16,10 +16,9 @@ struct memset_test_state { static int setup_test(void **state) { struct memset_test_state *s = malloc(sizeof(struct memset_test_state)); - u8 *buf = malloc(MEMSET_BUFFER_SZ); u8 *helper_buf = malloc(MEMSET_BUFFER_SZ); - if (!buf || !helper_buf) + if (!s || !buf || !helper_buf) goto error; s->base_buffer = buf; @@ -31,6 +30,7 @@ static int setup_test(void **state) error: free(buf); free(helper_buf); + free(s); return -1; }