sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/smmstore/ramstage.c: retry smmstore init up 5 times

Browse Source 
Retry calling the SMI 5 times in case the initial write to APM did not
cause SMM entry immediately.

Fixes occasional SMMSTORE initialization failure on Clevo NV4xPZ with
Intel i5-1240P processor. The issue was especially evident when all
logging in coreboot was disabled.

Based on SMMSTORE implementation in MrChromebox's fork of EDK2:
27854bc8c5

Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
This commit is contained in:
Michał Kopeć 2023-03-16 14:30:06 +01:00 committed by Tim Crawford
parent f941def9dd
commit 5b13dc0f5e
No known key found for this signature in database
GPG Key ID: 68E558D2BBD856E3
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/drivers/smmstore/ramstage.c
View File

@ -9,6 +9,7 @@
#include <smmstore.h> #include <smmstore.h>
#include <types.h> #include <types.h>
#include <cbmem.h> #include <cbmem.h>
#include <delay.h>
static struct smmstore_params_info info; static struct smmstore_params_info info;
@ -39,6 +40,7 @@ static void init_store(void *unused)
{ {
struct smmstore_params_init args; struct smmstore_params_init args;
uint32_t ret = ~0; uint32_t ret = ~0;
uint8_t retry = 5;
if (smmstore_get_info(&info) < 0) { if (smmstore_get_info(&info) < 0) {
printk(BIOS_INFO, "SMMSTORE: Failed to get meta data\n"); printk(BIOS_INFO, "SMMSTORE: Failed to get meta data\n");
@ -56,8 +58,17 @@ static void init_store(void *unused)
printk(BIOS_INFO, "SMMSTORE: Setting up SMI handler\n"); printk(BIOS_INFO, "SMMSTORE: Setting up SMI handler\n");
/* Issue SMI using APM to update the com buffer and to lock the SMMSTORE */ /*
ret = call_smm(APM_CNT_SMMSTORE, SMMSTORE_CMD_INIT, &args); * Issue SMI using APM to update the com buffer and to lock the SMMSTORE.
* Retry 5 times in case the SMI isn't triggered immediately.
*/
do {
ret = call_smm(APM_CNT_SMMSTORE, SMMSTORE_CMD_INIT, &args);
if (ret == SMMSTORE_RET_SUCCESS)
break;
mdelay(1);
} while (retry--);
if (ret != SMMSTORE_RET_SUCCESS) { if (ret != SMMSTORE_RET_SUCCESS) {
printk(BIOS_ERR, "SMMSTORE: Failed to install com buffer\n"); printk(BIOS_ERR, "SMMSTORE: Failed to install com buffer\n");