sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/kukui: Get write protection status from WP GPIO

Browse Source 
Write protection (get_write_protect_state) was hard-coded to 0 and
should be fixed to read from correct GPIO (PERIPHERAL_EN0 from
schematics).

BUG=b:130681408
TEST=make -j; boots on Kukui Rev2.
BRANCH=None

Change-Id: I75b98b1d587abe5e8cdf3df28ea661bc1ffa19f9
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32336
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: You-Cheng Syu <youcheng@google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Joel Kitching <kitching@google.com>
This commit is contained in:
Hung-Te Lin
2019-04-17 11:03:20 +08:00
committed by Julius Werner
parent 0873e27720
commit 5c1fadbf0f
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/kukui/chromeos.c
View File

@ -22,6 +22,7 @@
void setup_chromeos_gpios(void) void setup_chromeos_gpios(void)
{ {
gpio_input(GPIO_WP);
gpio_input_pullup(EC_IN_RW); gpio_input_pullup(EC_IN_RW);
gpio_input_pullup(EC_IRQ); gpio_input_pullup(EC_IRQ);
gpio_input_pullup(CR50_IRQ); gpio_input_pullup(CR50_IRQ);
@ -31,6 +32,8 @@ void setup_chromeos_gpios(void)
void fill_lb_gpios(struct lb_gpios *gpios) void fill_lb_gpios(struct lb_gpios *gpios)
{ {
struct lb_gpio chromeos_gpios[] = { struct lb_gpio chromeos_gpios[] = {
{GPIO_WP.id, ACTIVE_LOW,
!get_write_protect_state(), "write protect"},
{-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"}, {-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"},
{EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"}, {EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"},
{EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"}, {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"},
@ -41,7 +44,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
int get_write_protect_state(void) int get_write_protect_state(void)
{ {
return 0; return !gpio_get(GPIO_WP);
} }
int tis_plat_irq_status(void) int tis_plat_irq_status(void)

1
src/mainboard/google/kukui/gpio.h
View File

@ -18,6 +18,7 @@
#include <soc/gpio.h> #include <soc/gpio.h>
#define GPIO_WP GPIO(PERIPHERAL_EN0)
#define EC_IRQ GPIO(PERIPHERAL_EN1) #define EC_IRQ GPIO(PERIPHERAL_EN1)
#define EC_IN_RW GPIO(PERIPHERAL_EN14) #define EC_IN_RW GPIO(PERIPHERAL_EN14)
#define CR50_IRQ GPIO(PERIPHERAL_EN3) #define CR50_IRQ GPIO(PERIPHERAL_EN3)