sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/hardwaremain.c: Move creating ACPI structs to bootstate hooks

Browse Source 
hardwaremain.c is the common ramstage entry to all platforms so move
out ACPI code generation (x86 specific) to boot state hooks.

Another reason to do this is the following:
On some platforms that start in dram it makes little sense to have
separate stages. To reduce the complexity we want to call the ramstage
main function instead of loading a full stage. To make this scheme
more maintainable it makes sense to move out as much functionality
from the 'main' function as possible.

Change-Id: I613b927b9a193fc076ffb1b2a40c617965ce2645
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63414
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans
2022-04-06 18:28:07 +02:00
committed by Kyösti Mälkki
parent fd016126e4
commit 5cf02a4ecd
5 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/hardwaremain.c
View File

@ -23,7 +23,6 @@
#include <timer.h>
#include <timestamp.h>
#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <version.h>
static boot_state_t bs_pre_device(void *arg);
@ -462,13 +461,6 @@ void main(void)
/* Handoff sleep type from romstage. */
acpi_is_wakeup_s3();
/* Initialise GNVS early. */
if (CONFIG(ACPI_SOC_NVS))
acpi_create_gnvs();
if (CONFIG(CHROMEOS_NVS))
chromeos_init_chromeos_acpi();
/* Schedule the static boot state entries. */
boot_state_schedule_static_entries();