From 5d1494adda44dfaa0167aaa2f024c4ab351a82ad Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Thu, 9 May 2024 07:29:36 -0600 Subject: [PATCH] mb/system76/tgl: Update VBTs to version 250 Commit 4c7e97b26a34 ("Update fsp submodule to upstream master branch") included an update to the VBT from 240 to 250, breaking parsing of existing VBTs. After that commit, the VBT was parsed as (from gaze16-3060-b): [DEBUG] PCI: 00:02.0 init [INFO ] GMA: Found VBT in CBFS [INFO ] GMA: Found valid VBT in CBFS [INFO ] framebuffer_info: bytes_per_line: 4096, bits_per_pixel: 32 [INFO ] x_res x y_res: 1024 x 768, size: 3145728 at 0xd0000000 [DEBUG] PCI: 00:02.0 init finished in 6 msecs When the expected output is: [DEBUG] PCI: 00:00:02.0 init [INFO ] GMA: Found VBT in CBFS [INFO ] GMA: Found valid VBT in CBFS [INFO ] framebuffer_info: bytes_per_line: 7680, bits_per_pixel: 32 [INFO ] x_res x y_res: 1920 x 1080, size: 8294400 at 0xd0000000 [DEBUG] PCI: 00:00:02.0 init finished in 6 msecs Generate blobs for the new version using Intel Display Configuration Tool (DisCon) v3.3, based on the existing 237 and 240 VBTs. (For our edk2 payload, the UEFI GOP driver was updated to 17.0.1077.) Tested on all affected systems: - darp7 - galp5 - gaze16-3050 - gaze16-3060 - gaze16-3060-b - lemp10 - oryp8 Tested: - Boot splash displays on screen again - Firmware setup menu is rendered, at correct resolution Change-Id: I918356d9f660b985ee4408ef77544fbd071ab35f Signed-off-by: Tim Crawford Tested-by: Daniel Sutton Tested-by: Jacob Kauffmann Reviewed-on: https://review.coreboot.org/c/coreboot/+/82246 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer --- .../tgl-h/variants/gaze16-3050/data.vbt | Bin 8704 -> 8704 bytes .../tgl-h/variants/gaze16-3060/data.vbt | Bin 8704 -> 8704 bytes .../system76/tgl-h/variants/oryp8/data.vbt | Bin 8704 -> 8704 bytes .../system76/tgl-u/variants/darp7/data.vbt | Bin 8704 -> 8704 bytes .../system76/tgl-u/variants/galp5/data.vbt | Bin 8704 -> 8704 bytes .../system76/tgl-u/variants/lemp10/data.vbt | Bin 8704 -> 8704 bytes 6 files changed, 0 insertions(+), 0 deletions(-) diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt b/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt index 297522723cbb04e71925b45b20e99fafc9e89d1c..ff4bbb6b844a24b6be25e2f6e9404748ec2c7332 100644 GIT binary patch delta 680 zcmbV~F-QVo6oB7<|NUlXa%Y+Z6`T&yAR-n7CE;Mul1M{SgF`tqDKxp9gEU6+7NaGk zrD!_{+|ISO#wM3$X$qvF_s&}+km$kp-@V88-aUST09X=5{?=67V@$@KEoHzSaX=gqCq#{?6HTH`ToGNOM?4YF zgh#v(^QR!`&b5D@nZGnYQW&pbpwPQGl6kz*QyLU-u(z5<9Afj>@}V>O#Xx z$PR6!!IYcW2-~4!)zXFnKOWGBf2d_8Q08R`VA8@n-kbDZ*gcQ-36;3`vEM_ BQ*ZzP delta 669 zcmcJNF-rqM5JqS2vdJaUWF;a(nu~>HlEy+K7%*ZXf`wpX5kavKL=hXCOKX?7U?uqRXkv6Pr9rZ{HY&&xoyj;QFiXm<6^|dpTKr2OBqN`D)+1ktrZE3JZ@B%&E_F(Vl z2yIPI{a_tLPokq)dm4@@_;mF z2#U6Y!0lWbYHMtAX_lry8v5RO4H8K7hu^!qkKg;=$Kx7>M&V*sz9nxVi(L_GW-U2@ z1l%>Z`e6f100t_!#txZ>*KE=8zyjMZs>KEYuVt_-ePCODbpk-67mv2u{${SqA`eeT zq(LG%)WWK&w9<%X2U;%BB0pL=(41jAEAWbeN0X{}P#tNfCQ+vz2O15h;sFGj`U2t4 zN!r=PBDO4Nx{;+$v^ zZQ_A=Bs}7om^=VZcdq?&P5)){J;itd1DR-HpXcyWBsJK;?)3a`M4Zp1IW}bl9hq}K z<%xzR-PV^1MH4_v@1le8K~FLdo_1J+H>KrM2VkX7 zbCmY2wBfE+S6YyklgcZW)2=*Z8vA|al1aF0RcSn&3Z@xn=H|M<%<; zm9*p|{KHDm`VX4a&XoRIHFK8#qEWpxq|>=rkJ{o!qtFs~NT-%#tcr&Af#hW;qIatz dqC#N`afW=mrdM2~3;T+s%twpzZiGUk_6vc?M=k&W diff --git a/src/mainboard/system76/tgl-h/variants/oryp8/data.vbt b/src/mainboard/system76/tgl-h/variants/oryp8/data.vbt index 5641c17f76d843dfaf63eff3e2bd7105abb2a8bd..4165da8df51e89f8fb29876eede540a21bd79d8d 100644 GIT binary patch delta 680 zcmbV~u}i~16o=m>x!R_dq_!48g|ve>loF~Ss7QwjE|%iplNd|Eg%X6r> zNO4iz0z$WRanS$3sf%-Q5{iTG(hFFGBEImwkayqxa)h{Lw|qIn-?CR=V^>QxZIcfm z1NY6%eq0B`1qPyUl^rr4Z`p$5g9%nJ6wLw+o{zvZVPKiTG&WrG!Dd#lSrr4VB(+R- zsKrCAI-*%pD@rX9YWq@ihH<9!D$+ATuRao|h%p`RSZWiY22u;2wcwnjosZYV$JiEe z?eX5%Da8hv;>JV)OtVt(vY+h^lWNLY<~nQ;Tf`2rN7RTqaY~#K7etF_6OY6b;S(=J z>;P0y==xvJ|7F_)mHrAkGOdMuwTRbRR)KZwPR;#BORKYa6`Q<<4ljD2{6xWO#ELBD xz)+X45w#+_+*NuEKjJyB6D@G>J+Z=A1?P=5`VG@+!DiSnZm?%$yh*c@{01hfSOfq7 delta 669 zcmZp0X>ge!!8%{@6@$U#LPp_<1_G=f7{nOzCc3_7V`boPU|^hV&zQ={FnKAXT0H}U z0D}Sp3@9+LFdWNZ5D;M4uOI*xWQiP+Cyt0B zQ6Z|tHE}~Y#698N0gc|A|1-z_(tJf>Jb-~rRIs5X@Ki)O%p=nytb4AD5Rb%a+aAA$ z8Qs>$MgX*FJm`t&@)5>2YQ>%pfopnJOiVEy-~GcU0Udh-Z#3BEu{3@L=IFl+X_Ik= dkLCcD%uQmk_G+F9uKQ}`P|84yHqS#3{2ObUT=D<_ delta 715 zcmcJNy-UMD6u{qIa*b_Tb7~Qxps9lv6`Muy3oJAu2!ey)B(_vRaH)uk4(aMA@AN=lK-u-yIOHy$w?ol5*NUwn-c1Tav;p_`~ zVX-=2k1()mK*Su`Bp@!ykO#oQ1{F5w@LmAU>9Ng&A_1V`DX}qEk%PxA)Zk8PQFY)* zO$!RP)IOwUDs5S6Ug&Y@)uoqEUZJHOm719jhqIJcZqb4{akycrDGNYqvVfk~xJ164 z7Y_HkkG{M+0n!M3Ya}PTG`BPDx%nWoEQ`Sul1G-1Riub)BYQ07frrTWQiP+Cyt0B zQ6Z|tHE}~Y#698N0gc|A|1-z_(tJf>Jb-~rRIs5X@Ki)O%p=nytb4AD5Rb%a+aAA$ z8Qs>$MgX*FJm`t&@)5>2YQ>%pfopnJOiVEy-~GcU0Udh-Z#3BEu{3@L=IFl+X_Ik= dkLCcD%uQmk_G+F9uKQ}`P|84yHqS#3{2ObUT=D<_ delta 715 zcmcJNy-UMD6u{qIa*b_Tb7~Qxps9lv6`Muy3oJAu2!ey)B(_vRaH)uk4(aMA@AN=lK-u-yIOHy$w?ol5*NUwn-c1Tav;p_`~ zVX-=2k1()mK*Su`Bp@!ykO#oQ1{F5w@LmAU>9Ng&A_1V`DX}qEk%PxA)Zk8PQFY)* zO$!RP)IOwUDs5S6Ug&Y@)uoqEUZJHOm719jhqIJcZqb4{akycrDGNYqvVfk~xJ164 z7Y_HkkG{M+0n!M3Ya}PTG`BPDx%nWoEQ`Sul1G-1Riub)BYQ07frrT{kTH1kSve7ULr+^VS@)MG1JwC z5L{PMEw2uS4GhG>MRve!ykwJk8%(gAqS!3p@RR}5WNpiIssjKD9c%z*buNoCPr&^V zX%LEZG!NCNZbM9Js-sy_i%ZSh)i$J-?|7#4($e#Z+afO06Q@Y+SZYQ$F59Cy@1)0_ zO3lgo-Gdm$x@e--&+9zyD@OsccLq!>fMJ%9u|J=K7WmdFuB zqC`}Q8gWb95jOEac=kc1nJfR?qkp-4LrZUhj*M5arN;4`M-*5_riEGmy}^S@I9lIx z`BcnkmNqp3pw8ooJFJNzOmEjq?hlTe+998rV;a8u#?Sm34*K6H*ixct{PZu;e;HI~ fV++L$bPvv5NHYYVF@VN9U(rXO8d|f#zH9ZwHXM|d@PV@W3=6a;&x8f(M$piG9 z>JYiVyr8+CZS>{r1V}aTt&yy(Qo9^0kF||l4KfWzksLCEEFcAB4cTIv0}d{B5rG^b z7swTIi`*fxWvoQ~kMIv!JSg8JD#~i|uS}y8_!lLVWLy#JY)I@eO